Skip to content

Commit a384130

Browse files
authored
Merge pull request #187 from lonewolf3739/usage
TypeError: Can't instantiate abstract class TracerProvider with abstract methods get_tracer
2 parents c841110 + 1cdd6b0 commit a384130

File tree

15 files changed

+7
-56
lines changed
  • instrumentation
    • opentelemetry-instrumentation-aiopg/src/opentelemetry/instrumentation/aiopg
    • opentelemetry-instrumentation-boto/src/opentelemetry/instrumentation/boto
    • opentelemetry-instrumentation-botocore/src/opentelemetry/instrumentation/botocore
    • opentelemetry-instrumentation-celery/src/opentelemetry/instrumentation/celery
    • opentelemetry-instrumentation-dbapi/src/opentelemetry/instrumentation/dbapi
    • opentelemetry-instrumentation-elasticsearch/src/opentelemetry/instrumentation/elasticsearch
    • opentelemetry-instrumentation-jinja2/src/opentelemetry/instrumentation/jinja2
    • opentelemetry-instrumentation-mysql/src/opentelemetry/instrumentation/mysql
    • opentelemetry-instrumentation-psycopg2/src/opentelemetry/instrumentation/psycopg2
    • opentelemetry-instrumentation-pymemcache/src/opentelemetry/instrumentation/pymemcache
    • opentelemetry-instrumentation-pymongo/src/opentelemetry/instrumentation/pymongo
    • opentelemetry-instrumentation-pymysql/src/opentelemetry/instrumentation/pymysql
    • opentelemetry-instrumentation-redis/src/opentelemetry/instrumentation/redis
    • opentelemetry-instrumentation-sqlalchemy/src/opentelemetry/instrumentation/sqlalchemy
    • opentelemetry-instrumentation-sqlite3/src/opentelemetry/instrumentation/sqlite3

15 files changed

+7
-56
lines changed

Diff for: instrumentation/opentelemetry-instrumentation-aiopg/src/opentelemetry/instrumentation/aiopg/wrappers.py

-3
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,6 @@
2323
2424
from opentelemetry import trace
2525
from opentelemetry.instrumentation.aiopg import trace_integration
26-
from opentelemetry.trace import TracerProvider
27-
28-
trace.set_tracer_provider(TracerProvider())
2926
3027
trace_integration(aiopg.connection, "_connect", "postgresql", "sql")
3128

Diff for: instrumentation/opentelemetry-instrumentation-boto/src/opentelemetry/instrumentation/boto/__init__.py

+1-4
Original file line numberDiff line numberDiff line change
@@ -26,15 +26,12 @@
2626
2727
.. code:: python
2828
29-
from opentelemetry import trace
3029
from opentelemetry.instrumentation.boto import BotoInstrumentor
31-
from opentelemetry.sdk.trace import TracerProvider
3230
import boto
3331
34-
trace.set_tracer_provider(TracerProvider())
3532
3633
# Instrument Boto
37-
BotoInstrumentor().instrument(tracer_provider=trace.get_tracer_provider())
34+
BotoInstrumentor().instrument()
3835
3936
# This will create a span with Boto-specific attributes
4037
ec2 = boto.ec2.connect_to_region("us-west-2")

Diff for: instrumentation/opentelemetry-instrumentation-botocore/src/opentelemetry/instrumentation/botocore/__init__.py

+1-6
Original file line numberDiff line numberDiff line change
@@ -27,17 +27,12 @@
2727
2828
.. code:: python
2929
30-
from opentelemetry import trace
3130
from opentelemetry.instrumentation.botocore import BotocoreInstrumentor
32-
from opentelemetry.sdk.trace import TracerProvider
3331
import botocore
3432
35-
trace.set_tracer_provider(TracerProvider())
3633
3734
# Instrument Botocore
38-
BotocoreInstrumentor().instrument(
39-
tracer_provider=trace.get_tracer_provider()
40-
)
35+
BotocoreInstrumentor().instrument()
4136
4237
# This will create a span with Botocore-specific attributes
4338
session = botocore.session.get_session()

Diff for: instrumentation/opentelemetry-instrumentation-celery/src/opentelemetry/instrumentation/celery/__init__.py

-6
Original file line numberDiff line numberDiff line change
@@ -30,19 +30,13 @@
3030
3131
.. code:: python
3232
33-
from opentelemetry import trace
34-
from opentelemetry.sdk.trace import TracerProvider
35-
from opentelemetry.sdk.trace.export import BatchExportSpanProcessor
3633
from opentelemetry.instrumentation.celery import CeleryInstrumentor
3734
3835
from celery import Celery
3936
from celery.signals import worker_process_init
4037
4138
@worker_process_init.connect(weak=False)
4239
def init_celery_tracing(*args, **kwargs):
43-
trace.set_tracer_provider(TracerProvider())
44-
span_processor = BatchExportSpanProcessor(ConsoleSpanExporter())
45-
trace.get_tracer_provider().add_span_processor(span_processor)
4640
CeleryInstrumentor().instrument()
4741
4842
app = Celery("tasks", broker="amqp://localhost")

Diff for: instrumentation/opentelemetry-instrumentation-dbapi/src/opentelemetry/instrumentation/dbapi/__init__.py

-3
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,8 @@
2525
import mysql.connector
2626
import pyodbc
2727
28-
from opentelemetry import trace
2928
from opentelemetry.instrumentation.dbapi import trace_integration
30-
from opentelemetry.trace import TracerProvider
3129
32-
trace.set_tracer_provider(TracerProvider())
3330
3431
# Ex: mysql.connector
3532
trace_integration(mysql.connector, "connect", "mysql", "sql")

Diff for: instrumentation/opentelemetry-instrumentation-elasticsearch/src/opentelemetry/instrumentation/elasticsearch/__init__.py

+2-5
Original file line numberDiff line numberDiff line change
@@ -21,15 +21,12 @@
2121
2222
.. code-block:: python
2323
24-
from opentelemetry import trace
2524
from opentelemetry.instrumentation.elasticsearch import ElasticsearchInstrumentor
26-
from opentelemetry.sdk.trace import TracerProvider
2725
import elasticsearch
2826
29-
trace.set_tracer_provider(TracerProvider())
3027
3128
# instrument elasticsearch
32-
ElasticsearchInstrumentor().instrument(tracer_provider=trace.get_tracer_provider())
29+
ElasticsearchInstrumentor().instrument()
3330
3431
# Using elasticsearch as normal now will automatically generate spans
3532
es = elasticsearch.Elasticsearch()
@@ -46,7 +43,7 @@
4643
4744
.. code-block:: python
4845
49-
ElasticSearchInstrumentor("my-custom-prefix").instrument()
46+
ElasticsearchInstrumentor("my-custom-prefix").instrument()
5047
"""
5148

5249
import functools

Diff for: instrumentation/opentelemetry-instrumentation-jinja2/src/opentelemetry/instrumentation/jinja2/__init__.py

-3
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,7 @@
2727
2828
from jinja2 import Environment, FileSystemLoader
2929
from opentelemetry.instrumentation.jinja2 import Jinja2Instrumentor
30-
from opentelemetry import trace
31-
from opentelemetry.trace import TracerProvider
3230
33-
trace.set_tracer_provider(TracerProvider())
3431
3532
Jinja2Instrumentor().instrument()
3633

Diff for: instrumentation/opentelemetry-instrumentation-mysql/src/opentelemetry/instrumentation/mysql/__init__.py

-4
Original file line numberDiff line numberDiff line change
@@ -24,12 +24,8 @@
2424
.. code:: python
2525
2626
import mysql.connector
27-
from opentelemetry import trace
28-
from opentelemetry.trace import TracerProvider
2927
from opentelemetry.instrumentation.mysql import MySQLInstrumentor
3028
31-
trace.set_tracer_provider(TracerProvider())
32-
3329
MySQLInstrumentor().instrument()
3430
3531
cnx = mysql.connector.connect(database="MySQL_Database")

Diff for: instrumentation/opentelemetry-instrumentation-psycopg2/src/opentelemetry/instrumentation/psycopg2/__init__.py

-3
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,8 @@
2424
.. code-block:: python
2525
2626
import psycopg2
27-
from opentelemetry import trace
28-
from opentelemetry.sdk.trace import TracerProvider
2927
from opentelemetry.instrumentation.psycopg2 import Psycopg2Instrumentor
3028
31-
trace.set_tracer_provider(TracerProvider())
3229
3330
Psycopg2Instrumentor().instrument()
3431

Diff for: instrumentation/opentelemetry-instrumentation-pymemcache/src/opentelemetry/instrumentation/pymemcache/__init__.py

+2-3
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,10 @@
2424
2525
.. code-block:: python
2626
27-
from opentelemetry import trace
28-
from opentelemetry.sdk.trace import TracerProvider
2927
from opentelemetry.instrumentation.pymemcache import PymemcacheInstrumentor
30-
trace.set_tracer_provider(TracerProvider())
28+
3129
PymemcacheInstrumentor().instrument()
30+
3231
from pymemcache.client.base import Client
3332
client = Client(('localhost', 11211))
3433
client.set('some_key', 'some_value')

Diff for: instrumentation/opentelemetry-instrumentation-pymongo/src/opentelemetry/instrumentation/pymongo/__init__.py

-3
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,8 @@
2424
.. code:: python
2525
2626
from pymongo import MongoClient
27-
from opentelemetry import trace
28-
from opentelemetry.trace import TracerProvider
2927
from opentelemetry.instrumentation.pymongo import PymongoInstrumentor
3028
31-
trace.set_tracer_provider(TracerProvider())
3229
3330
PymongoInstrumentor().instrument()
3431
client = MongoClient()

Diff for: instrumentation/opentelemetry-instrumentation-pymysql/src/opentelemetry/instrumentation/pymysql/__init__.py

-3
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,8 @@
2424
.. code:: python
2525
2626
import pymysql
27-
from opentelemetry import trace
2827
from opentelemetry.instrumentation.pymysql import PyMySQLInstrumentor
29-
from opentelemetry.sdk.trace import TracerProvider
3028
31-
trace.set_tracer_provider(TracerProvider())
3229
3330
PyMySQLInstrumentor().instrument()
3431

Diff for: instrumentation/opentelemetry-instrumentation-redis/src/opentelemetry/instrumentation/redis/__init__.py

+1-4
Original file line numberDiff line numberDiff line change
@@ -27,15 +27,12 @@
2727
2828
.. code:: python
2929
30-
from opentelemetry import trace
3130
from opentelemetry.instrumentation.redis import RedisInstrumentor
32-
from opentelemetry.sdk.trace import TracerProvider
3331
import redis
3432
35-
trace.set_tracer_provider(TracerProvider())
3633
3734
# Instrument redis
38-
RedisInstrumentor().instrument(tracer_provider=trace.get_tracer_provider())
35+
RedisInstrumentor().instrument()
3936
4037
# This will report a span with the default settings
4138
client = redis.StrictRedis(host="localhost", port=6379)

Diff for: instrumentation/opentelemetry-instrumentation-sqlalchemy/src/opentelemetry/instrumentation/sqlalchemy/__init__.py

-3
Original file line numberDiff line numberDiff line change
@@ -28,12 +28,9 @@
2828
2929
from sqlalchemy import create_engine
3030
31-
from opentelemetry import trace
3231
from opentelemetry.instrumentation.sqlalchemy import SQLAlchemyInstrumentor
33-
from opentelemetry.sdk.trace import TracerProvider
3432
import sqlalchemy
3533
36-
trace.set_tracer_provider(TracerProvider())
3734
engine = create_engine("sqlite:///:memory:")
3835
SQLAlchemyInstrumentor().instrument(
3936
engine=engine,

Diff for: instrumentation/opentelemetry-instrumentation-sqlite3/src/opentelemetry/instrumentation/sqlite3/__init__.py

-3
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,8 @@
2424
.. code:: python
2525
2626
import sqlite3
27-
from opentelemetry import trace
28-
from opentelemetry.trace import TracerProvider
2927
from opentelemetry.instrumentation.sqlite3 import SQLite3Instrumentor
3028
31-
trace.set_tracer_provider(TracerProvider())
3229
3330
SQLite3Instrumentor().instrument()
3431

0 commit comments

Comments
 (0)