Skip to content

Commit a6cd4aa

Browse files
committed
Add a comment explaining private attribute usage
1 parent cbebbbf commit a6cd4aa

File tree

1 file changed

+2
-0
lines changed
  • instrumentation/opentelemetry-instrumentation-httpx/src/opentelemetry/instrumentation/httpx

1 file changed

+2
-0
lines changed

Diff for: instrumentation/opentelemetry-instrumentation-httpx/src/opentelemetry/instrumentation/httpx/__init__.py

+2
Original file line numberDiff line numberDiff line change
@@ -564,6 +564,8 @@ def _instrument(self, **kwargs):
564564
tracer_provider = kwargs.get("tracer_provider")
565565
_InstrumentedClient._tracer_provider = tracer_provider
566566
_InstrumentedAsyncClient._tracer_provider = tracer_provider
567+
# Intentionally using a private attribute here, see:
568+
# https://github.com/open-telemetry/opentelemetry-python-contrib/pull/2538#discussion_r1610603719
567569
httpx.Client = httpx._api.Client = _InstrumentedClient
568570
httpx.AsyncClient = _InstrumentedAsyncClient
569571

0 commit comments

Comments
 (0)