Skip to content

Commit b0e30ce

Browse files
committed
Upate reference version of OTel
1 parent 01b26e2 commit b0e30ce

File tree

3 files changed

+52
-32
lines changed

3 files changed

+52
-32
lines changed

sdk-extension/opentelemetry-sdk-extension-aws/setup.cfg

+2-2
Original file line numberDiff line numberDiff line change
@@ -39,15 +39,15 @@ package_dir=
3939
=src
4040
packages=find_namespace:
4141
install_requires =
42-
opentelemetry-api == 0.15.dev0
42+
opentelemetry-api == 0.15.b0
4343

4444
[options.entry_points]
4545
opentelemetry_propagator =
4646
aws_xray = opentelemetry.sdk.extension.aws.trace.propagation.aws_xray_format:AwsXRayFormat
4747

4848
[options.extras_require]
4949
test =
50-
opentelemetry-test == 0.14.b0
50+
opentelemetry-test == 0.15.b0
5151

5252
[options.packages.find]
5353
where = src

sdk-extension/opentelemetry-sdk-extension-aws/tests/trace/propagation/test_aws_xray_format.py

+48-28
Original file line numberDiff line numberDiff line change
@@ -24,12 +24,12 @@
2424
)
2525
import opentelemetry.trace as trace_api
2626
from opentelemetry.trace import (
27-
DEFAULT_TRACE_OPTIONS,
28-
DEFAULT_TRACE_STATE,
29-
INVALID_SPAN_CONTEXT,
30-
SpanContext,
31-
TraceFlags,
32-
set_span_in_context,
27+
DEFAULT_TRACE_OPTIONS,
28+
DEFAULT_TRACE_STATE,
29+
INVALID_SPAN_CONTEXT,
30+
SpanContext,
31+
TraceFlags,
32+
set_span_in_context,
3333
TraceState
3434
)
3535
from opentelemetry.trace.propagation.textmap import (
@@ -71,16 +71,36 @@ def build_test_context(
7171
)
7272

7373
def build_dict_with_xray_trace_header(
74-
trace_id=f"{AwsXRayFormat.TRACE_ID_VERSION}{AwsXRayFormat.TRACE_ID_DELIMITER}{TRACE_ID_BASE16[:AwsXRayFormat.TRACE_ID_FIRST_PART_LENGTH]}{AwsXRayFormat.TRACE_ID_DELIMITER}{TRACE_ID_BASE16[AwsXRayFormat.TRACE_ID_FIRST_PART_LENGTH:]}",
74+
trace_id="{}{}{}{}{}".format(
75+
AwsXRayFormat.TRACE_ID_VERSION,
76+
AwsXRayFormat.TRACE_ID_DELIMITER,
77+
TRACE_ID_BASE16[:AwsXRayFormat.TRACE_ID_FIRST_PART_LENGTH],
78+
AwsXRayFormat.TRACE_ID_DELIMITER,
79+
TRACE_ID_BASE16[AwsXRayFormat.TRACE_ID_FIRST_PART_LENGTH:],
80+
),
7581
span_id=SPAN_ID_BASE16,
7682
sampled="0",
7783
):
7884
carrier = CaseInsensitiveDict()
79-
85+
8086
carrier[AwsXRayFormat.TRACE_HEADER_KEY] = (
81-
f"{AwsXRayFormat.TRACE_ID_KEY}{AwsXRayFormat.KEY_AND_VALUE_DELIMITER}{trace_id}{AwsXRayFormat.KV_PAIR_DELIMITER}"
82-
f"{AwsXRayFormat.PARENT_ID_KEY}{AwsXRayFormat.KEY_AND_VALUE_DELIMITER}{span_id}{AwsXRayFormat.KV_PAIR_DELIMITER}"
83-
f"{AwsXRayFormat.SAMPLED_FLAG_KEY}{AwsXRayFormat.KEY_AND_VALUE_DELIMITER}{sampled}"
87+
"{}{}{}{}".format(
88+
AwsXRayFormat.TRACE_ID_KEY,
89+
AwsXRayFormat.KEY_AND_VALUE_DELIMITER,
90+
trace_id,
91+
AwsXRayFormat.KV_PAIR_DELIMITER,
92+
),
93+
"{}{}{}{}".format(
94+
AwsXRayFormat.PARENT_ID_KEY,
95+
AwsXRayFormat.KEY_AND_VALUE_DELIMITER,
96+
span_id,
97+
AwsXRayFormat.KV_PAIR_DELIMITER,
98+
),
99+
"{}{}{}".format(
100+
AwsXRayFormat.SAMPLED_FLAG_KEY,
101+
AwsXRayFormat.KEY_AND_VALUE_DELIMITER,
102+
sampled,
103+
)
84104
)
85105

86106
return carrier
@@ -96,12 +116,12 @@ class AwsXRayPropagatorTest(unittest.TestCase):
96116
carrier_setter: Setter[TextMapPropagatorT] = CaseInsensitiveDict.__setitem__
97117
carrier_getter: Getter[TextMapPropagatorT] = get_as_list
98118
XRAY_PROPAGATOR = AwsXRayFormat()
99-
119+
100120
# Inject Tests
101121

102122
def test_inject_into_non_sampled_context(self):
103123
carrier = CaseInsensitiveDict()
104-
124+
105125
AwsXRayPropagatorTest.XRAY_PROPAGATOR.inject(
106126
AwsXRayPropagatorTest.carrier_setter,
107127
carrier,
@@ -121,13 +141,13 @@ def test_inject_into_non_sampled_context(self):
121141

122142
def test_inject_into_sampled_context(self):
123143
carrier = CaseInsensitiveDict()
124-
144+
125145
AwsXRayPropagatorTest.XRAY_PROPAGATOR.inject(
126146
AwsXRayPropagatorTest.carrier_setter,
127147
carrier,
128148
build_test_context(trace_flags=TraceFlags(TraceFlags.SAMPLED))
129149
)
130-
150+
131151
self.assertTrue(
132152
set(
133153
carrier.items()
@@ -138,16 +158,16 @@ def test_inject_into_sampled_context(self):
138158
),
139159
'Failed to inject into context that was already sampled'
140160
)
141-
161+
142162
def test_inject_into_context_with_non_default_state(self):
143163
carrier = CaseInsensitiveDict()
144-
164+
145165
AwsXRayPropagatorTest.XRAY_PROPAGATOR.inject(
146166
AwsXRayPropagatorTest.carrier_setter,
147167
carrier,
148168
build_test_context(trace_state=TraceState({"foo" : "bar"}))
149169
)
150-
170+
151171
# TODO: (NathanielRN) Assert trace state when the propagator supports it
152172
self.assertTrue(
153173
set(
@@ -183,7 +203,7 @@ def test_extract_empty_carrier_from_invalid_context(self):
183203
get_extracted_span_context(actual_context_encompassing_extracted),
184204
INVALID_SPAN_CONTEXT
185205
)
186-
206+
187207
def test_extract_sampled_context(self):
188208
actual_context_encompassing_extracted = AwsXRayPropagatorTest.XRAY_PROPAGATOR.extract(
189209
AwsXRayPropagatorTest.carrier_getter,
@@ -223,7 +243,7 @@ def test_extract_different_order(self):
223243
get_extracted_span_context(actual_context_encompassing_extracted),
224244
get_extracted_span_context(build_test_context())
225245
)
226-
246+
227247
def test_extract_with_additional_fields(self):
228248
default_xray_trace_header_dict = build_dict_with_xray_trace_header()
229249
xray_trace_header_dict_with_extra_fields = CaseInsensitiveDict(
@@ -240,7 +260,7 @@ def test_extract_with_additional_fields(self):
240260
get_extracted_span_context(actual_context_encompassing_extracted),
241261
get_extracted_span_context(build_test_context())
242262
)
243-
263+
244264
def test_extract_invalid_xray_trace_header(self):
245265
actual_context_encompassing_extracted = AwsXRayPropagatorTest.XRAY_PROPAGATOR.extract(
246266
AwsXRayPropagatorTest.carrier_getter,
@@ -253,20 +273,20 @@ def test_extract_invalid_xray_trace_header(self):
253273
get_extracted_span_context(actual_context_encompassing_extracted),
254274
INVALID_SPAN_CONTEXT
255275
)
256-
276+
257277
def test_extract_invalid_trace_id(self):
258278
actual_context_encompassing_extracted = AwsXRayPropagatorTest.XRAY_PROPAGATOR.extract(
259279
AwsXRayPropagatorTest.carrier_getter,
260280
build_dict_with_xray_trace_header(
261-
trace_id="abcdefghijklmnopqrstuvwxyzabcdef"
281+
trace_id="abcdefghijklmnopqrstuvwxyz123456"
262282
),
263283
)
264284

265285
self.assertEqual(
266286
get_extracted_span_context(actual_context_encompassing_extracted),
267287
INVALID_SPAN_CONTEXT
268288
)
269-
289+
270290
def test_extract_invalid_trace_id_size(self):
271291
actual_context_encompassing_extracted = AwsXRayPropagatorTest.XRAY_PROPAGATOR.extract(
272292
AwsXRayPropagatorTest.carrier_getter,
@@ -292,7 +312,7 @@ def test_extract_invalid_span_id(self):
292312
get_extracted_span_context(actual_context_encompassing_extracted),
293313
INVALID_SPAN_CONTEXT
294314
)
295-
315+
296316
def test_extract_invalid_span_id_size(self):
297317
actual_context_encompassing_extracted = AwsXRayPropagatorTest.XRAY_PROPAGATOR.extract(
298318
AwsXRayPropagatorTest.carrier_getter,
@@ -305,7 +325,7 @@ def test_extract_invalid_span_id_size(self):
305325
get_extracted_span_context(actual_context_encompassing_extracted),
306326
INVALID_SPAN_CONTEXT
307327
)
308-
328+
309329
def test_extract_invalid_empty_sampled_flag(self):
310330
actual_context_encompassing_extracted = AwsXRayPropagatorTest.XRAY_PROPAGATOR.extract(
311331
AwsXRayPropagatorTest.carrier_getter,
@@ -318,7 +338,7 @@ def test_extract_invalid_empty_sampled_flag(self):
318338
get_extracted_span_context(actual_context_encompassing_extracted),
319339
INVALID_SPAN_CONTEXT
320340
)
321-
341+
322342
def test_extract_invalid_sampled_flag_size(self):
323343
actual_context_encompassing_extracted = AwsXRayPropagatorTest.XRAY_PROPAGATOR.extract(
324344
AwsXRayPropagatorTest.carrier_getter,
@@ -331,7 +351,7 @@ def test_extract_invalid_sampled_flag_size(self):
331351
get_extracted_span_context(actual_context_encompassing_extracted),
332352
INVALID_SPAN_CONTEXT
333353
)
334-
354+
335355
def test_extract_invalid_non_numeric_sampled_flag(self):
336356
actual_context_encompassing_extracted = AwsXRayPropagatorTest.XRAY_PROPAGATOR.extract(
337357
AwsXRayPropagatorTest.carrier_getter,

sdk-extension/opentelemetry-sdk-extension-aws/tests/trace/test_aws_xray_ids_generator.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -25,15 +25,15 @@
2525
class AwsXRayIdsGeneratorTest(unittest.TestCase):
2626
def test_ids_are_valid(self):
2727
ids_generator = AwsXRayIdsGenerator()
28-
for _ in range(1_000):
28+
for _ in range(1000):
2929
trace_id = ids_generator.generate_trace_id()
3030
self.assertTrue(trace_id != INVALID_TRACE_ID)
3131
span_id = ids_generator.generate_span_id()
3232
self.assertTrue(span_id != INVALID_TRACE_ID)
3333

3434
def test_id_timestamps_are_acceptable_for_xray(self):
3535
ids_generator = AwsXRayIdsGenerator()
36-
for _ in range(1_000):
36+
for _ in range(1000):
3737
trace_id = ids_generator.generate_trace_id()
3838
trace_id_time = trace_id >> 96
3939
current_time = int(datetime.datetime.utcnow().timestamp())

0 commit comments

Comments
 (0)