Skip to content

Commit b1ac40f

Browse files
committed
Remove unecessary dict casting
1 parent 2297294 commit b1ac40f

File tree

1 file changed

+16
-16
lines changed

1 file changed

+16
-16
lines changed

instrumentation/opentelemetry-instrumentation-botocore/tests/test_botocore_instrumentation.py

+16-16
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ def test_traced_client(self):
5858
span = spans[0]
5959
self.assertEqual(len(spans), 1)
6060
self.assertEqual(
61-
dict(span.attributes),
61+
span.attributes,
6262
{
6363
"aws.operation": "DescribeInstances",
6464
"aws.region": "us-west-2",
@@ -106,7 +106,7 @@ def test_s3_client(self):
106106
span = spans[0]
107107
self.assertEqual(len(spans), 2)
108108
self.assertEqual(
109-
dict(span.attributes),
109+
span.attributes,
110110
{
111111
"aws.operation": "ListBuckets",
112112
"aws.region": "us-west-2",
@@ -123,7 +123,7 @@ def test_s3_client(self):
123123
assert spans
124124
span = spans[2]
125125
self.assertEqual(
126-
dict(span.attributes),
126+
span.attributes,
127127
{
128128
"aws.operation": "ListObjects",
129129
"aws.region": "us-west-2",
@@ -144,7 +144,7 @@ def test_s3_put(self):
144144
spans = self.memory_exporter.get_finished_spans()
145145
assert spans
146146
self.assertEqual(len(spans), 3)
147-
create_bucket_attributes = dict(spans[0].attributes)
147+
create_bucket_attributes = spans[0].attributes
148148
self.assertEqual(
149149
create_bucket_attributes,
150150
{
@@ -154,7 +154,7 @@ def test_s3_put(self):
154154
"http.status_code": 200,
155155
},
156156
)
157-
put_object_attributes = dict(spans[1].attributes)
157+
put_object_attributes = spans[1].attributes
158158
self.assertEqual(
159159
put_object_attributes,
160160
{
@@ -165,7 +165,7 @@ def test_s3_put(self):
165165
},
166166
)
167167
self.assertTrue("params.Body" not in spans[1].attributes.keys())
168-
get_object_attributes = dict(spans[2].attributes)
168+
get_object_attributes = spans[2].attributes
169169
self.assertEqual(
170170
get_object_attributes,
171171
{
@@ -186,7 +186,7 @@ def test_sqs_client(self):
186186
assert spans
187187
span = spans[0]
188188
self.assertEqual(len(spans), 1)
189-
actual = dict(span.attributes)
189+
actual = span.attributes
190190
self.assertRegex(actual["aws.request_id"], r"[A-Z0-9]{52}")
191191
del actual["aws.request_id"]
192192
self.assertEqual(
@@ -214,7 +214,7 @@ def test_sqs_send_message(self):
214214
spans = self.memory_exporter.get_finished_spans()
215215
assert spans
216216
self.assertEqual(len(spans), 2)
217-
create_queue_attributes = dict(spans[0].attributes)
217+
create_queue_attributes = spans[0].attributes
218218
self.assertRegex(
219219
create_queue_attributes["aws.request_id"], r"[A-Z0-9]{52}"
220220
)
@@ -228,7 +228,7 @@ def test_sqs_send_message(self):
228228
"http.status_code": 200,
229229
},
230230
)
231-
send_msg_attributes = dict(spans[1].attributes)
231+
send_msg_attributes = spans[1].attributes
232232
self.assertRegex(
233233
send_msg_attributes["aws.request_id"], r"[A-Z0-9]{52}"
234234
)
@@ -257,7 +257,7 @@ def test_kinesis_client(self):
257257
span = spans[0]
258258
self.assertEqual(len(spans), 1)
259259
self.assertEqual(
260-
dict(span.attributes),
260+
span.attributes,
261261
{
262262
"aws.operation": "ListStreams",
263263
"aws.region": "us-east-1",
@@ -302,7 +302,7 @@ def test_lambda_client(self):
302302
span = spans[0]
303303
self.assertEqual(len(spans), 1)
304304
self.assertEqual(
305-
dict(span.attributes),
305+
span.attributes,
306306
{
307307
"aws.operation": "ListFunctions",
308308
"aws.region": "us-east-1",
@@ -322,7 +322,7 @@ def test_kms_client(self):
322322
span = spans[0]
323323
self.assertEqual(len(spans), 1)
324324
self.assertEqual(
325-
dict(span.attributes),
325+
span.attributes,
326326
{
327327
"aws.operation": "ListKeys",
328328
"aws.region": "us-east-1",
@@ -345,7 +345,7 @@ def test_sts_client(self):
345345
span = spans[0]
346346
self.assertEqual(len(spans), 1)
347347
self.assertEqual(
348-
dict(span.attributes),
348+
span.attributes,
349349
{
350350
"aws.operation": "GetCallerIdentity",
351351
"aws.region": "us-east-1",
@@ -383,7 +383,7 @@ def test_dynamodb_client(self):
383383
spans = self.memory_exporter.get_finished_spans()
384384
assert spans
385385
self.assertEqual(len(spans), 3)
386-
create_table_attributes = dict(spans[0].attributes)
386+
create_table_attributes = spans[0].attributes
387387
self.assertRegex(
388388
create_table_attributes["aws.request_id"], r"[A-Z0-9]{52}"
389389
)
@@ -398,7 +398,7 @@ def test_dynamodb_client(self):
398398
"http.status_code": 200,
399399
},
400400
)
401-
put_item_attributes = dict(spans[1].attributes)
401+
put_item_attributes = spans[1].attributes
402402
self.assertRegex(
403403
put_item_attributes["aws.request_id"], r"[A-Z0-9]{52}"
404404
)
@@ -413,7 +413,7 @@ def test_dynamodb_client(self):
413413
"http.status_code": 200,
414414
},
415415
)
416-
get_item_attributes = dict(spans[2].attributes)
416+
get_item_attributes = spans[2].attributes
417417
self.assertRegex(
418418
get_item_attributes["aws.request_id"], r"[A-Z0-9]{52}"
419419
)

0 commit comments

Comments
 (0)