Skip to content

Commit bdbc249

Browse files
authored
Use traceflags object (#472)
1 parent 45c94e7 commit bdbc249

File tree

3 files changed

+11
-1
lines changed

3 files changed

+11
-1
lines changed

CHANGELOG.md

+4
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
66

77
## [Unreleased](https://github.com/open-telemetry/opentelemetry-python-contrib/compare/v0.200...HEAD)
88

9+
### Changed
10+
- `opentelemetry-propagator-ot-trace` Use `TraceFlags` object in `extract`
11+
([#472](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/472))
12+
913
### Added
1014
- Move `opentelemetry-instrumentation` from core repository
1115
([#465](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/465))

propagator/opentelemetry-propagator-ot-trace/src/opentelemetry/propagators/ot_trace/__init__.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ def extract(
8585
trace_id=int(traceid, 16),
8686
span_id=int(spanid, 16),
8787
is_remote=True,
88-
trace_flags=traceflags,
88+
trace_flags=TraceFlags(traceflags),
8989
)
9090
),
9191
context,

propagator/opentelemetry-propagator-ot-trace/tests/test_ot_trace_propagator.py

+6
Original file line numberDiff line numberDiff line change
@@ -248,6 +248,9 @@ def test_extract_trace_id_span_id_sampled_true(self):
248248
self.assertEqual(hex(span_context.span_id)[2:], "e457b5a2e4d86bd1")
249249
self.assertTrue(span_context.is_remote)
250250
self.assertEqual(span_context.trace_flags, TraceFlags.SAMPLED)
251+
self.assertIsInstance(
252+
get_current_span().get_span_context().trace_flags, TraceFlags
253+
)
251254

252255
def test_extract_trace_id_span_id_sampled_false(self):
253256
"""Test valid trace_id, span_id and sampled false"""
@@ -268,6 +271,9 @@ def test_extract_trace_id_span_id_sampled_false(self):
268271
self.assertEqual(hex(span_context.span_id)[2:], "e457b5a2e4d86bd1")
269272
self.assertTrue(span_context.is_remote)
270273
self.assertEqual(span_context.trace_flags, TraceFlags.DEFAULT)
274+
self.assertIsInstance(
275+
get_current_span().get_span_context().trace_flags, TraceFlags
276+
)
271277

272278
def test_extract_malformed_trace_id(self):
273279
"""Test extraction with malformed trace_id"""

0 commit comments

Comments
 (0)