File tree 3 files changed +32
-21
lines changed
3 files changed +32
-21
lines changed Original file line number Diff line number Diff line change 1
- # Code owners file.
2
- # This file controls who is tagged for review for any given pull request.
3
- #
4
- # What is a "CODEOWNER"?
5
- #
6
- # A CODEOWNER lends their expertise to a specific package hosted by an OpenTelemetry repository.
7
- #
8
- # A CODEOWNER MUST:
9
- # - introduce themselves on the CNCF OTel Python channel: https://cloud-native.slack.com/archives/C01PD4HUVBL
10
- # - have enough knowledge of the corresponding instrumented library
11
- # - respond to issues
12
- # - fix failing unit tests or any other blockers to the CI/CD workflow
13
- # - update usage of `opentelemetry-python-core` APIs upon the introduction of breaking changes
14
- # - be a member of the OpenTelemetry community so that the `component-owners.yml` action to automatically assign CODEOWNERS to PRs works correctly.
15
- #
1
+ # This file is only used as a way to assign any change to the approvers team
2
+ # except for a change in any of the instrumentations. The actual codeowners
3
+ # of the instrumentations are in .github/component_owners.yml.
16
4
17
-
18
- # For anything not explicitly taken by someone else:
5
+ # Assigns any change to the approvers team...
19
6
* @ open-telemetry/opentelemetry-python-contrib-approvers
20
7
8
+ # ...except for changes in any instrumentation.
9
+ /instrumentation
10
+
21
11
# Learn about CODEOWNERS file format:
22
12
# https://help.github.com/en/articles/about-code-owners
23
- #
24
- # Learn about membership in OpenTelemetry community:
25
- # https://github.com/open-telemetry/community/blob/main/community-membership.md
26
- #
Original file line number Diff line number Diff line change @@ -43,9 +43,23 @@ components:
43
43
44
44
instrumentation/opentelemetry-instrumentation-urllib :
45
45
- shalevr
46
+ - ocelotl
46
47
47
48
instrumentation/opentelemetry-instrumentation-urllib3 :
48
49
- shalevr
50
+ - ocelotl
49
51
50
52
instrumentation/opentelemetry-instrumentation-sqlalchemy :
51
53
- shalevr
54
+
55
+ instrumentation/opentelemetry-instrumentation-flask :
56
+ - ocelotl
57
+
58
+ instrumentation/opentelemetry-instrumentation-jinja2 :
59
+ - ocelotl
60
+
61
+ instrumentation/opentelemetry-instrumentation-logging :
62
+ - ocelotl
63
+
64
+ instrumentation/opentelemetry-instrumentation-requests :
65
+ - ocelotl
Original file line number Diff line number Diff line change @@ -124,6 +124,17 @@ Open a pull request against the main `opentelemetry-python-contrib` repo.
124
124
as ` work-in-progress ` , or mark it as [ ` draft ` ] ( https://github.blog/2019-02-14-introducing-draft-pull-requests/ ) .
125
125
* Make sure CLA is signed and CI is clear.
126
126
127
+ ### How to Get PRs Reviewed
128
+
129
+ The maintainers and approvers of this repo are not experts in every instrumentation there is here.
130
+ In fact each one of us knows enough about them to only review a few. Unfortunately it can be hard
131
+ to find enough experts in every instrumentation to quickly review every instrumentation PR. The
132
+ instrumentation experts are listed in ` .github/component_owners.yml ` with their corresponding files
133
+ or directories that they own. The owners listed there will be notified when PRs that modify their
134
+ files are opened.
135
+
136
+ If you are not getting reviews, please contact the respective owners directly.
137
+
127
138
### How to Get PRs Merged
128
139
129
140
A PR is considered to be ** ready to merge** when:
You can’t perform that action at this time.
0 commit comments