Skip to content

Commit cc9f8ab

Browse files
committed
Remove [test] package from urllib instrumentation
Fixes #2225
1 parent fbda226 commit cc9f8ab

File tree

3 files changed

+22
-7
lines changed

3 files changed

+22
-7
lines changed

Diff for: instrumentation/opentelemetry-instrumentation-urllib/pyproject.toml

-4
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,6 @@ dependencies = [
3232

3333
[project.optional-dependencies]
3434
instruments = []
35-
test = [
36-
"httpretty ~= 1.0",
37-
"opentelemetry-test-utils == 0.45b0.dev",
38-
]
3935

4036
[project.entry-points.opentelemetry_instrumentor]
4137
urllib = "opentelemetry.instrumentation.urllib:URLLibInstrumentor"
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
asgiref==3.7.2
2+
attrs==23.2.0
3+
Deprecated==1.2.14
4+
httpretty==1.1.4
5+
importlib-metadata==6.11.0
6+
iniconfig==2.0.0
7+
packaging==23.2
8+
pluggy==1.4.0
9+
py==1.11.0
10+
py-cpuinfo==9.0.0
11+
pytest==7.1.3
12+
pytest-benchmark==4.0.0
13+
tomli==2.0.1
14+
typing_extensions==4.9.0
15+
wrapt==1.16.0
16+
zipp==3.17.0
17+
-e opentelemetry-instrumentation
18+
-e util/opentelemetry-util-http
19+
-e instrumentation/opentelemetry-instrumentation-urllib

Diff for: tox.ini

+3-3
Original file line numberDiff line numberDiff line change
@@ -341,7 +341,7 @@ commands_pre =
341341

342342
grpc: pip install {toxinidir}/instrumentation/opentelemetry-instrumentation-grpc[test]
343343

344-
,urllib,urllib3v-{1,2}: pip install {toxinidir}/util/opentelemetry-util-http
344+
urllib3v-{1,2}: pip install {toxinidir}/util/opentelemetry-util-http
345345

346346
wsgi: pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-wsgi/test-requirements.txt
347347

@@ -362,7 +362,7 @@ commands_pre =
362362
flask-1: pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-flask/test-requirements-1.txt
363363
flask-2: pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-flask/test-requirements-2.txt
364364

365-
urllib: pip install {toxinidir}/instrumentation/opentelemetry-instrumentation-urllib[test]
365+
urllib: pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-urllib/test-requirements.txt
366366

367367
urllib3v-{1,2}: pip install {toxinidir}/instrumentation/opentelemetry-instrumentation-urllib3[test]
368368

@@ -590,7 +590,7 @@ commands_pre =
590590
python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-sqlite3[test]
591591
pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-pyramid/test-requirements.txt
592592
pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-requests/test-requirements.txt
593-
python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-urllib[test]
593+
pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-urllib/test-requirements.txt
594594
python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-urllib3[test]
595595
python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-pymysql[test]
596596
# prerequisite: follow the instructions here https://github.com/PyMySQL/mysqlclient#install

0 commit comments

Comments
 (0)