Skip to content

Commit d0b37c4

Browse files
committed
Update aiohttp implementation
1 parent 5581bd5 commit d0b37c4

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

instrumentation/opentelemetry-instrumentation-aiohttp-client/src/opentelemetry/instrumentation/aiohttp_client/__init__.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@ async def on_request_start(
179179
return
180180

181181
http_method = params.method.upper()
182-
request_span_name = f"HTTP {http_method}"
182+
request_span_name = f"{http_method}"
183183
request_url = (
184184
remove_url_credentials(trace_config_ctx.url_filter(params.url))
185185
if callable(trace_config_ctx.url_filter)

instrumentation/opentelemetry-instrumentation-aiohttp-client/tests/test_aiohttp_client_integration.py

+7-6
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ def test_status_codes(self):
118118
self.assert_spans(
119119
[
120120
(
121-
"HTTP GET",
121+
"GET",
122122
(span_status, None),
123123
{
124124
SpanAttributes.HTTP_METHOD: "GET",
@@ -212,7 +212,7 @@ def strip_query_params(url: yarl.URL) -> str:
212212
self.assert_spans(
213213
[
214214
(
215-
"HTTP GET",
215+
"GET",
216216
(StatusCode.UNSET, None),
217217
{
218218
SpanAttributes.HTTP_METHOD: "GET",
@@ -246,7 +246,7 @@ async def do_request(url):
246246
self.assert_spans(
247247
[
248248
(
249-
"HTTP GET",
249+
"GET",
250250
(expected_status, None),
251251
{
252252
SpanAttributes.HTTP_METHOD: "GET",
@@ -273,7 +273,7 @@ async def request_handler(request):
273273
self.assert_spans(
274274
[
275275
(
276-
"HTTP GET",
276+
"GET",
277277
(StatusCode.ERROR, None),
278278
{
279279
SpanAttributes.HTTP_METHOD: "GET",
@@ -300,7 +300,7 @@ async def request_handler(request):
300300
self.assert_spans(
301301
[
302302
(
303-
"HTTP GET",
303+
"GET",
304304
(StatusCode.ERROR, None),
305305
{
306306
SpanAttributes.HTTP_METHOD: "GET",
@@ -329,7 +329,7 @@ async def do_request(url):
329329
self.assert_spans(
330330
[
331331
(
332-
"HTTP GET",
332+
"GET",
333333
(StatusCode.UNSET, None),
334334
{
335335
SpanAttributes.HTTP_METHOD: "GET",
@@ -380,6 +380,7 @@ def test_instrument(self):
380380
self.get_default_request(), self.URL, self.default_handler
381381
)
382382
span = self.assert_spans(1)
383+
self.assertEqual("GET", span.name)
383384
self.assertEqual("GET", span.attributes[SpanAttributes.HTTP_METHOD])
384385
self.assertEqual(
385386
f"http://{host}:{port}/test-path",

0 commit comments

Comments
 (0)