Skip to content

Commit d4ff08e

Browse files
committed
Fix more paths
1 parent 1077e46 commit d4ff08e

File tree

22 files changed

+75
-62
lines changed
  • exporter/opentelemetry-exporter-datadog/src/opentelemetry/exporter/datadog
  • instrumentation
    • opentelemetry-instrumentation-aiohttp-client/src/opentelemetry/instrumentation/aiohttp_client
    • opentelemetry-instrumentation-asgi/src/opentelemetry/instrumentation/asgi
    • opentelemetry-instrumentation-botocore
    • opentelemetry-instrumentation-celery/src/opentelemetry/instrumentation/celery
    • opentelemetry-instrumentation-django/src/opentelemetry/instrumentation/django
    • opentelemetry-instrumentation-elasticsearch/src/opentelemetry/instrumentation/elasticsearch
    • opentelemetry-instrumentation-falcon/src/opentelemetry/instrumentation/falcon
    • opentelemetry-instrumentation-flask/src/opentelemetry/instrumentation/flask
    • opentelemetry-instrumentation-grpc/src/opentelemetry/instrumentation/grpc
    • opentelemetry-instrumentation-pyramid/src/opentelemetry/instrumentation/pyramid
    • opentelemetry-instrumentation-requests
    • opentelemetry-instrumentation-tornado/src/opentelemetry/instrumentation/tornado
    • opentelemetry-instrumentation-urllib
    • opentelemetry-instrumentation-wsgi/src/opentelemetry/instrumentation/wsgi
  • sdk-extension/opentelemetry-sdk-extension-aws

22 files changed

+75
-62
lines changed

Diff for: exporter/opentelemetry-exporter-datadog/src/opentelemetry/exporter/datadog/__init__.py

+3-2
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,8 @@
3434
3535
.. code:: python
3636
37-
from opentelemetry import propagators, trace
37+
from opentelemetry.propagators.util import set_global_textmap
38+
from opentelemetry import trace
3839
from opentelemetry.exporter.datadog import DatadogExportSpanProcessor, DatadogSpanExporter
3940
from opentelemetry.exporter.datadog.propagator import DatadogFormat
4041
from opentelemetry.sdk.trace import TracerProvider
@@ -50,7 +51,7 @@
5051
trace.get_tracer_provider().add_span_processor(span_processor)
5152
5253
# Optional: use Datadog format for propagation in distributed traces
53-
propagators.set_global_textmap(DatadogFormat())
54+
set_global_textmap(DatadogFormat())
5455
5556
with tracer.start_as_current_span("foo"):
5657
print("Hello world!")

Diff for: instrumentation/opentelemetry-instrumentation-aiohttp-client/src/opentelemetry/instrumentation/aiohttp_client/__init__.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -62,15 +62,15 @@ def strip_query_params(url: yarl.URL) -> str:
6262
---
6363
"""
6464

65-
import socket
6665
import types
6766
import typing
6867

6968
import aiohttp
7069
import wrapt
7170

7271
from opentelemetry import context as context_api
73-
from opentelemetry import propagators, trace
72+
from opentelemetry.propagators.util import inject
73+
from opentelemetry import trace
7474
from opentelemetry.instrumentation.aiohttp_client.version import __version__
7575
from opentelemetry.instrumentation.instrumentor import BaseInstrumentor
7676
from opentelemetry.instrumentation.utils import (
@@ -181,7 +181,7 @@ async def on_request_start(
181181
trace.set_span_in_context(trace_config_ctx.span)
182182
)
183183

184-
propagators.inject(type(params.headers).__setitem__, params.headers)
184+
inject(type(params.headers).__setitem__, params.headers)
185185

186186
async def on_request_end(
187187
unused_session: aiohttp.ClientSession,

Diff for: instrumentation/opentelemetry-instrumentation-asgi/src/opentelemetry/instrumentation/asgi/__init__.py

+3-2
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,8 @@
2525

2626
from asgiref.compatibility import guarantee_single_callable
2727

28-
from opentelemetry import context, propagators, trace
28+
from opentelemetry import context, trace
29+
from opentelemetry.propagators.util import extract
2930
from opentelemetry.instrumentation.asgi.version import __version__ # noqa
3031
from opentelemetry.instrumentation.utils import http_status_to_status_code
3132
from opentelemetry.trace.propagation.textmap import DictGetter
@@ -185,7 +186,7 @@ async def __call__(self, scope, receive, send):
185186
if self.excluded_urls and self.excluded_urls.url_disabled(url):
186187
return await self.app(scope, receive, send)
187188

188-
token = context.attach(propagators.extract(carrier_getter, scope))
189+
token = context.attach(extract(carrier_getter, scope))
189190
span_name, additional_attributes = self.span_details_callback(scope)
190191

191192
try:

Diff for: instrumentation/opentelemetry-instrumentation-botocore/src/opentelemetry/instrumentation/botocore/__init__.py

+4-5
Original file line numberDiff line numberDiff line change
@@ -49,15 +49,14 @@
4949
import logging
5050

5151
from botocore.client import BaseClient
52-
from botocore.exceptions import ClientError, ParamValidationError
53-
from wrapt import ObjectProxy, wrap_function_wrapper
52+
from botocore.exceptions import ClientError
53+
from wrapt import wrap_function_wrapper
5454

5555
from opentelemetry import context as context_api
56-
from opentelemetry import propagators
56+
from opentelemetry.propagators.util import inject
5757
from opentelemetry.instrumentation.botocore.version import __version__
5858
from opentelemetry.instrumentation.instrumentor import BaseInstrumentor
5959
from opentelemetry.instrumentation.utils import unwrap
60-
from opentelemetry.sdk.trace import Resource
6160
from opentelemetry.trace import SpanKind, get_tracer
6261

6362
logger = logging.getLogger(__name__)
@@ -67,7 +66,7 @@
6766
def _patched_endpoint_prepare_request(wrapped, instance, args, kwargs):
6867
request = args[0]
6968
headers = request.headers
70-
propagators.inject(type(headers).__setitem__, headers)
69+
inject(type(headers).__setitem__, headers)
7170
return wrapped(*args, **kwargs)
7271

7372

Diff for: instrumentation/opentelemetry-instrumentation-botocore/tests/test_botocore_instrumentation.py

+6-4
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,9 @@
2828
mock_xray,
2929
)
3030

31-
from opentelemetry import propagators
31+
from opentelemetry.propagators.util import (
32+
set_global_textmap, get_global_textmap
33+
)
3234
from opentelemetry import trace as trace_api
3335
from opentelemetry.context import attach, detach, set_value
3436
from opentelemetry.instrumentation.botocore import BotocoreInstrumentor
@@ -381,14 +383,14 @@ def test_sts_client(self):
381383
@mock_ec2
382384
def test_propagator_injects_into_request(self):
383385
headers = {}
384-
previous_propagator = propagators.get_global_textmap()
386+
previous_propagator = get_global_textmap()
385387

386388
def check_headers(**kwargs):
387389
nonlocal headers
388390
headers = kwargs["request"].headers
389391

390392
try:
391-
propagators.set_global_textmap(MockTextMapPropagator())
393+
set_global_textmap(MockTextMapPropagator())
392394

393395
ec2 = self.session.create_client("ec2", region_name="us-west-2")
394396
ec2.meta.events.register_first(
@@ -424,7 +426,7 @@ def check_headers(**kwargs):
424426
)
425427

426428
finally:
427-
propagators.set_global_textmap(previous_propagator)
429+
set_global_textmap(previous_propagator)
428430

429431
@mock_xray
430432
def test_suppress_instrumentation_xray_client(self):

Diff for: instrumentation/opentelemetry-instrumentation-celery/src/opentelemetry/instrumentation/celery/__init__.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -52,12 +52,12 @@ def add(x, y):
5252
"""
5353

5454
import logging
55-
import signal
5655
from collections.abc import Iterable
5756

5857
from celery import signals # pylint: disable=no-name-in-module
5958

60-
from opentelemetry import propagators, trace
59+
from opentelemetry.propagators.util import extract, inject
60+
from opentelemetry import trace
6161
from opentelemetry.instrumentation.celery import utils
6262
from opentelemetry.instrumentation.celery.version import __version__
6363
from opentelemetry.instrumentation.instrumentor import BaseInstrumentor
@@ -128,7 +128,7 @@ def _trace_prerun(self, *args, **kwargs):
128128
return
129129

130130
request = task.request
131-
tracectx = propagators.extract(carrier_getter, request) or None
131+
tracectx = extract(carrier_getter, request) or None
132132

133133
logger.debug("prerun signal start task_id=%s", task_id)
134134

@@ -192,7 +192,7 @@ def _trace_before_publish(self, *args, **kwargs):
192192

193193
headers = kwargs.get("headers")
194194
if headers:
195-
propagators.inject(type(headers).__setitem__, headers)
195+
inject(type(headers).__setitem__, headers)
196196

197197
@staticmethod
198198
def _trace_after_publish(*args, **kwargs):

Diff for: instrumentation/opentelemetry-instrumentation-django/src/opentelemetry/instrumentation/django/middleware.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
carrier_getter,
2424
collect_request_attributes,
2525
)
26-
from opentelemetry.propagators import extract
26+
from opentelemetry.propagators.util import extract
2727
from opentelemetry.trace import SpanKind, get_tracer
2828
from opentelemetry.util.http import get_excluded_urls, get_traced_request_attrs
2929

Diff for: instrumentation/opentelemetry-instrumentation-elasticsearch/src/opentelemetry/instrumentation/elasticsearch/__init__.py

-4
Original file line numberDiff line numberDiff line change
@@ -46,17 +46,13 @@
4646
ElasticsearchInstrumentor("my-custom-prefix").instrument()
4747
"""
4848

49-
import functools
50-
import types
5149
from logging import getLogger
5250
from os import environ
5351

5452
import elasticsearch
5553
import elasticsearch.exceptions
56-
from wrapt import ObjectProxy
5754
from wrapt import wrap_function_wrapper as _wrap
5855

59-
from opentelemetry import context, propagators, trace
6056
from opentelemetry.instrumentation.elasticsearch.version import __version__
6157
from opentelemetry.instrumentation.instrumentor import BaseInstrumentor
6258
from opentelemetry.instrumentation.utils import unwrap

Diff for: instrumentation/opentelemetry-instrumentation-falcon/src/opentelemetry/instrumentation/falcon/__init__.py

+3-2
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,8 @@ def on_get(self, req, resp):
4949
import falcon
5050

5151
import opentelemetry.instrumentation.wsgi as otel_wsgi
52-
from opentelemetry import context, propagators, trace
52+
from opentelemetry.propagators.util import extract
53+
from opentelemetry import context, trace
5354
from opentelemetry.instrumentation.falcon.version import __version__
5455
from opentelemetry.instrumentation.instrumentor import BaseInstrumentor
5556
from opentelemetry.instrumentation.utils import (
@@ -109,7 +110,7 @@ def __call__(self, env, start_response):
109110
start_time = time_ns()
110111

111112
token = context.attach(
112-
propagators.extract(otel_wsgi.carrier_getter, env)
113+
extract(otel_wsgi.carrier_getter, env)
113114
)
114115
span = self._tracer.start_span(
115116
otel_wsgi.get_default_span_name(env),

Diff for: instrumentation/opentelemetry-instrumentation-flask/src/opentelemetry/instrumentation/flask/__init__.py

+3-2
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,8 @@ def hello():
5252
import flask
5353

5454
import opentelemetry.instrumentation.wsgi as otel_wsgi
55-
from opentelemetry import context, propagators, trace
55+
from opentelemetry import context, trace
56+
from opentelemetry.propagators.util import extract
5657
from opentelemetry.instrumentation.flask.version import __version__
5758
from opentelemetry.instrumentation.instrumentor import BaseInstrumentor
5859
from opentelemetry.util.http import get_excluded_urls
@@ -116,7 +117,7 @@ def _before_request():
116117
flask_request_environ = flask.request.environ
117118
span_name = name_callback()
118119
token = context.attach(
119-
propagators.extract(
120+
extract(
120121
otel_wsgi.carrier_getter, flask_request_environ
121122
)
122123
)

Diff for: instrumentation/opentelemetry-instrumentation-grpc/src/opentelemetry/instrumentation/grpc/_client.py

+3-2
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,8 @@
2424

2525
import grpc
2626

27-
from opentelemetry import propagators, trace
27+
from opentelemetry.propagators.util import inject
28+
from opentelemetry import trace
2829
from opentelemetry.instrumentation.grpc import grpcext
2930
from opentelemetry.instrumentation.grpc._utilities import RpcInfo
3031
from opentelemetry.trace.status import Status, StatusCode
@@ -59,7 +60,7 @@ def append_metadata(
5960
metadata[key] = value
6061

6162
# Inject current active span from the context
62-
propagators.inject(append_metadata, metadata)
63+
inject(append_metadata, metadata)
6364

6465

6566
def _make_future_done_callback(span, rpc_info):

Diff for: instrumentation/opentelemetry-instrumentation-grpc/src/opentelemetry/instrumentation/grpc/_server.py

+3-2
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,8 @@
2626

2727
import grpc
2828

29-
from opentelemetry import propagators, trace
29+
from opentelemetry.propagators.util import extract
30+
from opentelemetry import trace
3031
from opentelemetry.context import attach, detach
3132
from opentelemetry.trace.propagation.textmap import DictGetter
3233
from opentelemetry.trace.status import Status, StatusCode
@@ -181,7 +182,7 @@ def _set_remote_context(self, servicer_context):
181182
metadata = servicer_context.invocation_metadata()
182183
if metadata:
183184
md_dict = {md.key: md.value for md in metadata}
184-
ctx = propagators.extract(self._carrier_getter, md_dict)
185+
ctx = extract(self._carrier_getter, md_dict)
185186
token = attach(ctx)
186187
try:
187188
yield

Diff for: instrumentation/opentelemetry-instrumentation-pyramid/src/opentelemetry/instrumentation/pyramid/callbacks.py

+3-2
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@
66
from pyramid.tweens import EXCVIEW
77

88
import opentelemetry.instrumentation.wsgi as otel_wsgi
9-
from opentelemetry import context, propagators, trace
9+
from opentelemetry import context, trace
10+
from opentelemetry.propagators.util import extract
1011
from opentelemetry.instrumentation.pyramid.version import __version__
1112
from opentelemetry.util.http import get_excluded_urls
1213
from opentelemetry.util.providers import time_ns
@@ -64,7 +65,7 @@ def _before_traversal(event):
6465
start_time = request_environ.get(_ENVIRON_STARTTIME_KEY)
6566

6667
token = context.attach(
67-
propagators.extract(otel_wsgi.carrier_getter, request_environ)
68+
extract(otel_wsgi.carrier_getter, request_environ)
6869
)
6970
tracer = trace.get_tracer(__name__, __version__)
7071

Diff for: instrumentation/opentelemetry-instrumentation-requests/src/opentelemetry/instrumentation/requests/__init__.py

+4-5
Original file line numberDiff line numberDiff line change
@@ -36,18 +36,17 @@
3636
import functools
3737
import types
3838

39-
from requests import Timeout, URLRequired
40-
from requests.exceptions import InvalidSchema, InvalidURL, MissingSchema
4139
from requests.models import Response
4240
from requests.sessions import Session
4341
from requests.structures import CaseInsensitiveDict
4442

45-
from opentelemetry import context, propagators
43+
from opentelemetry.propagators.util import inject
44+
from opentelemetry import context
4645
from opentelemetry.instrumentation.instrumentor import BaseInstrumentor
4746
from opentelemetry.instrumentation.requests.version import __version__
4847
from opentelemetry.instrumentation.utils import http_status_to_status_code
4948
from opentelemetry.trace import SpanKind, get_tracer
50-
from opentelemetry.trace.status import Status, StatusCode
49+
from opentelemetry.trace.status import Status
5150

5251
# A key to a context variable to avoid creating duplicate spans when instrumenting
5352
# both, Session.request and Session.send, since Session.request calls into Session.send
@@ -135,7 +134,7 @@ def _instrumented_requests_call(
135134
span.set_attribute("http.url", url)
136135

137136
headers = get_or_create_headers()
138-
propagators.inject(type(headers).__setitem__, headers)
137+
inject(type(headers).__setitem__, headers)
139138

140139
token = context.attach(
141140
context.set_value(_SUPPRESS_REQUESTS_INSTRUMENTATION_KEY, True)

Diff for: instrumentation/opentelemetry-instrumentation-requests/tests/test_requests_integration.py

+7-4
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,10 @@
1919
import requests
2020

2121
import opentelemetry.instrumentation.requests
22-
from opentelemetry import context, propagators, trace
22+
from opentelemetry import context, trace
23+
from opentelemetry.propagators.util import (
24+
get_global_textmap, set_global_textmap
25+
)
2326
from opentelemetry.instrumentation.requests import RequestsInstrumentor
2427
from opentelemetry.sdk import resources
2528
from opentelemetry.test.mock_textmap import MockTextMapPropagator
@@ -191,9 +194,9 @@ def test_not_recording(self):
191194
self.assertFalse(mock_span.set_status.called)
192195

193196
def test_distributed_context(self):
194-
previous_propagator = propagators.get_global_textmap()
197+
previous_propagator = get_global_textmap()
195198
try:
196-
propagators.set_global_textmap(MockTextMapPropagator())
199+
set_global_textmap(MockTextMapPropagator())
197200
result = self.perform_request(self.URL)
198201
self.assertEqual(result.text, "Hello!")
199202

@@ -212,7 +215,7 @@ def test_distributed_context(self):
212215
)
213216

214217
finally:
215-
propagators.set_global_textmap(previous_propagator)
218+
set_global_textmap(previous_propagator)
216219

217220
def test_span_callback(self):
218221
RequestsInstrumentor().uninstrument()

Diff for: instrumentation/opentelemetry-instrumentation-tornado/src/opentelemetry/instrumentation/tornado/__init__.py

+3-2
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,8 @@ def get(self):
4343
import wrapt
4444
from wrapt import wrap_function_wrapper
4545

46-
from opentelemetry import context, propagators, trace
46+
from opentelemetry import context, trace
47+
from opentelemetry.propagators.util import extract
4748
from opentelemetry.instrumentation.instrumentor import BaseInstrumentor
4849
from opentelemetry.instrumentation.tornado.version import __version__
4950
from opentelemetry.instrumentation.utils import (
@@ -196,7 +197,7 @@ def _get_operation_name(handler, request):
196197

197198
def _start_span(tracer, handler, start_time) -> _TraceContext:
198199
token = context.attach(
199-
propagators.extract(carrier_getter, handler.request.headers,)
200+
extract(carrier_getter, handler.request.headers,)
200201
)
201202

202203
span = tracer.start_span(

Diff for: instrumentation/opentelemetry-instrumentation-tornado/src/opentelemetry/instrumentation/tornado/client.py

+3-2
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@
22

33
from tornado.httpclient import HTTPError, HTTPRequest
44

5-
from opentelemetry import propagators, trace
5+
from opentelemetry.propagators.util import inject
6+
from opentelemetry import trace
67
from opentelemetry.instrumentation.utils import http_status_to_status_code
78
from opentelemetry.trace.status import Status
89
from opentelemetry.util.providers import time_ns
@@ -50,7 +51,7 @@ def fetch_async(tracer, func, _, args, kwargs):
5051
span.set_attribute(key, value)
5152

5253
with tracer.use_span(span):
53-
propagators.inject(type(request.headers).__setitem__, request.headers)
54+
inject(type(request.headers).__setitem__, request.headers)
5455
future = func(*args, **kwargs)
5556
future.add_done_callback(
5657
functools.partial(_finish_tracing_callback, span=span)

0 commit comments

Comments
 (0)