Skip to content

Commit d948f21

Browse files
authored
Remove [test] package from flask instrumentation (#2127)
Fixes #2126
1 parent 5552db2 commit d948f21

File tree

5 files changed

+90
-18
lines changed

5 files changed

+90
-18
lines changed

Diff for: instrumentation/opentelemetry-instrumentation-flask/pyproject.toml

-5
Original file line numberDiff line numberDiff line change
@@ -37,11 +37,6 @@ dependencies = [
3737
instruments = [
3838
"flask >= 1.0",
3939
]
40-
test = [
41-
"opentelemetry-instrumentation-flask[instruments]",
42-
"markupsafe==2.1.2",
43-
"opentelemetry-test-utils == 0.45b0.dev",
44-
]
4540

4641
[project.entry-points.opentelemetry_instrumentor]
4742
flask = "opentelemetry.instrumentation.flask:FlaskInstrumentor"
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
asgiref==3.7.2
2+
attrs==23.2.0
3+
click==8.1.7
4+
Deprecated==1.2.14
5+
Flask==2.1.3
6+
importlib-metadata==6.11.0
7+
iniconfig==2.0.0
8+
itsdangerous==2.1.2
9+
Jinja2==3.1.3
10+
MarkupSafe==2.1.2
11+
packaging==23.2
12+
pluggy==1.4.0
13+
py==1.11.0
14+
py-cpuinfo==9.0.0
15+
pytest==7.1.3
16+
pytest-benchmark==4.0.0
17+
tomli==2.0.1
18+
typing_extensions==4.9.0
19+
Werkzeug==2.3.8
20+
wrapt==1.16.0
21+
zipp==3.17.0
22+
-e opentelemetry-instrumentation
23+
-e instrumentation/opentelemetry-instrumentation-wsgi
24+
-e util/opentelemetry-util-http
25+
-e instrumentation/opentelemetry-instrumentation-flask
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
asgiref==3.7.2
2+
attrs==23.2.0
3+
click==8.1.7
4+
Deprecated==1.2.14
5+
Flask==2.2.0
6+
importlib-metadata==6.11.0
7+
iniconfig==2.0.0
8+
itsdangerous==2.1.2
9+
Jinja2==3.1.3
10+
MarkupSafe==2.1.2
11+
packaging==23.2
12+
pluggy==1.4.0
13+
py==1.11.0
14+
py-cpuinfo==9.0.0
15+
pytest==7.1.3
16+
pytest-benchmark==4.0.0
17+
tomli==2.0.1
18+
typing_extensions==4.9.0
19+
Werkzeug==2.3.8
20+
wrapt==1.16.0
21+
zipp==3.17.0
22+
-e opentelemetry-instrumentation
23+
-e instrumentation/opentelemetry-instrumentation-wsgi
24+
-e util/opentelemetry-util-http
25+
-e instrumentation/opentelemetry-instrumentation-flask
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
asgiref==3.7.2
2+
attrs==23.2.0
3+
blinker==1.7.0
4+
click==8.1.7
5+
Deprecated==1.2.14
6+
Flask==3.0.2
7+
importlib-metadata==6.11.0
8+
iniconfig==2.0.0
9+
itsdangerous==2.1.2
10+
Jinja2==3.1.3
11+
MarkupSafe==2.1.2
12+
packaging==23.2
13+
pluggy==1.4.0
14+
py==1.11.0
15+
py-cpuinfo==9.0.0
16+
pytest==7.1.3
17+
pytest-benchmark==4.0.0
18+
tomli==2.0.1
19+
typing_extensions==4.9.0
20+
Werkzeug==3.0.1
21+
wrapt==1.16.0
22+
zipp==3.17.0
23+
-e opentelemetry-instrumentation
24+
-e instrumentation/opentelemetry-instrumentation-wsgi
25+
-e util/opentelemetry-util-http
26+
-e instrumentation/opentelemetry-instrumentation-flask

Diff for: tox.ini

+14-13
Original file line numberDiff line numberDiff line change
@@ -83,9 +83,14 @@ envlist =
8383
pypy3-test-instrumentation-fastapi
8484

8585
; opentelemetry-instrumentation-flask
86-
py3{8,9,10,11}-test-instrumentation-flask-{213,220}
87-
py3{8,9,10,11}-test-instrumentation-flask-{300}
88-
pypy3-test-instrumentation-flask-{213,220}
86+
; The numbers at the end of the environment names
87+
; below mean these dependencies are being used:
88+
; 0: Flask ==2.1.3 Werkzeug <3.0.0
89+
; 1: Flask ==2.2.0 Werkzeug <3.0.0
90+
; 2: Flask >=3.0.0 Werkzeug >=3.0.0
91+
py3{8,9,10,11}-test-instrumentation-flask-{0,1}
92+
py3{8,9,10,11}-test-instrumentation-flask-{2}
93+
pypy3-test-instrumentation-flask-{0,1}
8994

9095
; opentelemetry-instrumentation-urllib
9196
py3{8,9,10,11}-test-instrumentation-urllib
@@ -277,12 +282,6 @@ deps =
277282
falcon-1: falcon ==1.4.1
278283
falcon-2: falcon >=2.0.0,<3.0.0
279284
falcon-3: falcon >=3.0.0,<4.0.0
280-
flask-213: Flask ==2.1.3
281-
flask-213: Werkzeug <3.0.0
282-
flask-220: Flask ==2.2.0
283-
flask-220: Werkzeug <3.0.0
284-
flask-300: Flask >=3.0.0
285-
flask-300: Werkzeug >=3.0.0
286285
grpc: pytest-asyncio
287286
sqlalchemy-11: sqlalchemy>=1.1,<1.2
288287
sqlalchemy-14: aiosqlite
@@ -339,8 +338,8 @@ commands_pre =
339338

340339
grpc: pip install {toxinidir}/instrumentation/opentelemetry-instrumentation-grpc[test]
341340

342-
falcon-{1,2,3},flask-{213,220,300},django-{1,2,3,4},pyramid,tornado,starlette,fastapi,aiohttp,httpx-{18,21},requests,urllib,urllib3v-{1,2},wsgi: pip install {toxinidir}/util/opentelemetry-util-http
343-
wsgi,falcon-{1,2,3},flask-{213,220,300},django-{1,2,3,4},pyramid: pip install {toxinidir}/instrumentation/opentelemetry-instrumentation-wsgi[test]
341+
falcon-{1,2,3},django-{1,2,3,4},pyramid,tornado,starlette,fastapi,aiohttp,httpx-{18,21},requests,urllib,urllib3v-{1,2},wsgi: pip install {toxinidir}/util/opentelemetry-util-http
342+
wsgi,falcon-{1,2,3},django-{1,2,3,4},pyramid: pip install {toxinidir}/instrumentation/opentelemetry-instrumentation-wsgi[test]
344343
django-{3,4},starlette,fastapi: pip install {toxinidir}/instrumentation/opentelemetry-instrumentation-asgi
345344

346345
asyncpg: pip install {toxinidir}/instrumentation/opentelemetry-instrumentation-asyncpg[test]
@@ -354,7 +353,9 @@ commands_pre =
354353

355354
falcon-{1,2,3}: pip install {toxinidir}/instrumentation/opentelemetry-instrumentation-falcon[test]
356355

357-
flask-{213,220,300}: pip install {toxinidir}/instrumentation/opentelemetry-instrumentation-flask[test]
356+
flask-0: pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-flask/test-requirements-0.txt
357+
flask-1: pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-flask/test-requirements-1.txt
358+
flask-2: pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-flask/test-requirements-2.txt
358359

359360
urllib: pip install {toxinidir}/instrumentation/opentelemetry-instrumentation-urllib[test]
360361

@@ -548,7 +549,7 @@ commands_pre =
548549
python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-grpc[test]
549550
python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-falcon[test]
550551
python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-boto[test]
551-
python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-flask[test]
552+
pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-flask/test-requirements-2.txt
552553
python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-sqlalchemy[test]
553554
python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-cassandra[test]
554555
python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-celery[test]

0 commit comments

Comments
 (0)