Skip to content

Commit de3c3b2

Browse files
author
Azfaar Qureshi
committed
adding assertions for every test
1 parent d285779 commit de3c3b2

File tree

1 file changed

+66
-35
lines changed

1 file changed

+66
-35
lines changed

tests/opentelemetry-docker-tests/tests/prometheus-remote-write-cortex/prometheus_remote_write_cortex_test.py

+66-35
Original file line numberDiff line numberDiff line change
@@ -26,46 +26,77 @@ def setUp(self):
2626
)
2727

2828
def test_export_counter(self):
29-
requests_counter = self.meter.create_counter(
30-
name="counter",
31-
description="test_export_counter",
32-
unit="1",
33-
value_type=int,
34-
)
35-
requests_counter.add(25, self.labels)
29+
try:
30+
requests_counter = self.meter.create_counter(
31+
name="counter",
32+
description="test_export_counter",
33+
unit="1",
34+
value_type=int,
35+
)
36+
requests_counter.add(25, self.labels)
37+
except Exception as e:
38+
self.fail(
39+
"Export counter failed with unexpected error {}".format(e)
40+
)
3641

3742
def test_export_valuerecorder(self):
38-
requests_size = self.meter.create_valuerecorder(
39-
name="valuerecorder",
40-
description="test_export_valuerecorder",
41-
unit="1",
42-
value_type=int,
43-
)
44-
requests_size.record(25, self.labels)
43+
try:
44+
requests_size = self.meter.create_valuerecorder(
45+
name="valuerecorder",
46+
description="test_export_valuerecorder",
47+
unit="1",
48+
value_type=int,
49+
)
50+
requests_size.record(25, self.labels)
51+
except Exception as e:
52+
self.fail(
53+
"Export valuerecorder failed with unexpected error {}".format(
54+
e
55+
)
56+
)
4557

4658
def test_export_updowncounter(self):
47-
requests_size = self.meter.create_updowncounter(
48-
name="updowncounter",
49-
description="test_export_updowncounter",
50-
unit="1",
51-
value_type=int,
52-
)
53-
requests_size.add(-25, self.labels)
59+
try:
60+
requests_size = self.meter.create_updowncounter(
61+
name="updowncounter",
62+
description="test_export_updowncounter",
63+
unit="1",
64+
value_type=int,
65+
)
66+
requests_size.add(-25, self.labels)
67+
except Exception as e:
68+
self.fail(
69+
"Export updowncounter failed with unexpected error {}".format(
70+
e
71+
)
72+
)
5473

5574
def test_export_sumobserver(self):
56-
self.meter.register_sumobserver(
57-
callback=observer_callback,
58-
name="sumobserver",
59-
description="test_export_sumobserver",
60-
unit="1",
61-
value_type=float,
62-
)
75+
try:
76+
self.meter.register_sumobserver(
77+
callback=observer_callback,
78+
name="sumobserver",
79+
description="test_export_sumobserver",
80+
unit="1",
81+
value_type=float,
82+
)
83+
except Exception as e:
84+
self.fail(
85+
"Export sumobserver failed with unexpected error {}".format(e)
86+
)
6387

6488
def test_export_updownsumobserver(self):
65-
self.meter.register_updownsumobserver(
66-
callback=observer_callback,
67-
name="updownsumobserver",
68-
description="test_export_updownsumobserver",
69-
unit="1",
70-
value_type=float,
71-
)
89+
try:
90+
self.meter.register_updownsumobserver(
91+
callback=observer_callback,
92+
name="updownsumobserver",
93+
description="test_export_updownsumobserver",
94+
unit="1",
95+
value_type=float,
96+
)
97+
except Exception as e:
98+
self.fail(
99+
"Export updownsumobserver failed with unexpected error {}".format(
100+
e
101+
)
102+
)

0 commit comments

Comments
 (0)