Skip to content

Commit e1d5e5c

Browse files
committed
allow older grpc versions to raise AttributeError
1 parent 618748d commit e1d5e5c

File tree

1 file changed

+1
-5
lines changed
  • instrumentation/opentelemetry-instrumentation-grpc/src/opentelemetry/instrumentation/grpc

1 file changed

+1
-5
lines changed

Diff for: instrumentation/opentelemetry-instrumentation-grpc/src/opentelemetry/instrumentation/grpc/_server.py

+1-5
Original file line numberDiff line numberDiff line change
@@ -115,11 +115,7 @@ def set_trailing_metadata(self, *args, **kwargs):
115115
return self._servicer_context.set_trailing_metadata(*args, **kwargs)
116116

117117
def trailing_metadata(self):
118-
# This method was added to grpc.ServicerContext in gRPC v1.38.0. We do
119-
# this hasattr check to maintain support for earlier gRPC versions.
120-
if hasattr(self._servicer_context, "trailing_metadata"):
121-
return self._servicer_context.trailing_metadata()
122-
raise NotImplementedError()
118+
return self._servicer_context.trailing_metadata()
123119

124120
def abort(self, code, details):
125121
self.code = code

0 commit comments

Comments
 (0)