Skip to content

Commit f534ebd

Browse files
committed
Merge branch 'main' of github.com:open-telemetry/opentelemetry-python-contrib into feat/LambdaMetrics
Signed-off-by: Anthony J Mirabella <[email protected]>
2 parents 8d10a80 + 6ed2c56 commit f534ebd

File tree

3 files changed

+3
-2
lines changed
  • instrumentation
    • opentelemetry-instrumentation-aiohttp-client/src/opentelemetry/instrumentation/aiohttp_client
    • opentelemetry-instrumentation-aws-lambda/src/opentelemetry/instrumentation/aws_lambda

3 files changed

+3
-2
lines changed

CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1515
([#1212](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/1212))
1616
- `opentelemetry-instrumentation-aws-lambda` Flush `MeterProvider` at end of function invocation.
1717
([#1613](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/1613))
18+
- Fix aiohttp bug with unset `trace_configs` ([#1592](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/1592))
1819

1920
### Fixed
2021

instrumentation/opentelemetry-instrumentation-aiohttp-client/src/opentelemetry/instrumentation/aiohttp_client/__init__.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -280,7 +280,7 @@ def instrumented_init(wrapped, instance, args, kwargs):
280280
if context_api.get_value(_SUPPRESS_INSTRUMENTATION_KEY):
281281
return wrapped(*args, **kwargs)
282282

283-
client_trace_configs = list(kwargs.get("trace_configs", ()))
283+
client_trace_configs = list(kwargs.get("trace_configs") or [])
284284
client_trace_configs.extend(trace_configs)
285285

286286
trace_config = create_trace_config(

instrumentation/opentelemetry-instrumentation-aws-lambda/src/opentelemetry/instrumentation/aws_lambda/__init__.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -381,7 +381,7 @@ def _instrumented_lambda_handler_call(
381381
_meter_provider.force_flush(rem)
382382
except Exception: # pylint: disable=broad-except
383383
logger.exception(
384-
f"MeterProvider failed to flush traces"
384+
f"MeterProvider failed to flush metrics"
385385
)
386386
else:
387387
logger.warning(

0 commit comments

Comments
 (0)