Skip to content

AWS Lambda Instrumentation should offer request_hook/response_hook callable arguments. #1140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
whardier opened this issue Jun 19, 2022 · 2 comments
Assignees
Labels

Comments

@whardier
Copy link

Currently double-wrapping a function in order to produce similar functionality.

@srikanthccv srikanthccv added good first issue Good for newcomers help wanted Extra attention is needed instrumentation labels Sep 9, 2022
@gangsd92
Copy link

gangsd92 commented Oct 2, 2022

@srikanthccv Can you assign this issue to me please. I'd like to work on this. Also share any context that'd be helpful to get started :) Thanks

@srikanthccv
Copy link
Member

Take a look at the hooks for other instrumentation libraries like flask https://github.com/open-telemetry/opentelemetry-python-contrib/tree/main/instrumentation/opentelemetry-instrumentation-flask#requestresponse-hooks. They provide a way to perform some pre and post request operations on the span. We need to provide the similar feature for lambda instrumentation library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants