Skip to content

is_instrumented_by_opentelemetry is not set in _InstrumentedFastAPI class #1312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TheAnshul756 opened this issue Sep 2, 2022 · 0 comments · Fixed by #1313
Closed

is_instrumented_by_opentelemetry is not set in _InstrumentedFastAPI class #1312

TheAnshul756 opened this issue Sep 2, 2022 · 0 comments · Fixed by #1313
Assignees
@TheAnshul756
Labels
bug Something isn't working

Comments

@TheAnshul756
Copy link
Contributor

Steps to reproduce
If instrument_app function is called for already instrumented object of _InstrumentedFastAPI then it will add Opentelemtery middleware again in the user_middleware list as is_instrumented_by_opentelemetry is not set in the __init__ function of _InstrumentedFastAPI.

What is the expected behavior?
If a fastapi app is already instrumented, i.e., it already has otel middleware in it then it shouldn't add another one.

What is the actual behavior?
Multiple otel middlewares are added.
@TheAnshul756 TheAnshul756 added the bug Something isn't working label Sep 2, 2022
@TheAnshul756 TheAnshul756 mentioned this issue Sep 2, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheAnshul756 TheAnshul756

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix check of is_otel_instrumented TheAnshul756/opentelemetry-python-contrib
1 participant
@TheAnshul756