You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe your environment Building a metapackage builder and noticed some potential issues with starlette instrumentation. Going to avoid providing starlette as part of our metapackager for now (and just assume fastapi instrumentation will be enough for our base)
Steps to reproduce
Attempt to compile a requirements file listing the most recent fastapi and most recent instrumentation for both starlette and fastapi.
What is the expected behavior?
Install both instrumentation for starlette and fastapi along with most recent starlette and fastapi supported by fastapi instrumentation.
What is the actual behavior?
Starlette instrumentation restricted to 0.13.x while most recent fastapi requires a pinned version of starlette at 0.20.4
@whardier
I believe the instrumentations were created and supported versions were tested at the time independent of each other (it was an oversight that we didn't account for this specific use case).
@ocelotl@srikanthccv
Curious do we want to handle this use case? Even if we do test and bump the latest supported version of starlette to ~= 0.20.4, there's nothing stopping fastapi to depend on later versions of starlette. Since starlette is still in alpha, I'm not sure about the implications of doing >= and having to solve breaking changes.
Might be another example of supporting incompatible versions (slightly related to: #1008) in which we handle case-by-case.
Describe your environment Building a metapackage builder and noticed some potential issues with starlette instrumentation. Going to avoid providing starlette as part of our metapackager for now (and just assume fastapi instrumentation will be enough for our base)
Steps to reproduce
Attempt to compile a requirements file listing the most recent fastapi and most recent instrumentation for both starlette and fastapi.
What is the expected behavior?
Install both instrumentation for starlette and fastapi along with most recent starlette and fastapi supported by fastapi instrumentation.
What is the actual behavior?
Starlette instrumentation restricted to
0.13.x
while most recent fastapi requires a pinned version of starlette at0.20.4
Additional context
Just noting this to see if this is an obvious oversight.
The text was updated successfully, but these errors were encountered: