Skip to content

Update database driver instrumentor docs for instrument_connection #3089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
7 tasks done
tammy-baylis-swi opened this issue Dec 10, 2024 · 2 comments
Closed
7 tasks done
Assignees
Labels

Comments

@tammy-baylis-swi
Copy link
Contributor

tammy-baylis-swi commented Dec 10, 2024

What problem do you want to solve?

I would be helpful if existing database driver instrumentors got doc and docstring updates to better describe instrument_connection and how it should be used. Currently their Usage examples show how to use instrument, but not instrument_connection. Some of the docs do not have docstring at all for instrument_connection.

Describe the solution you'd like

Update the docs and docstrings of these instrumentors that have instrument_connection methods defined:

I am excluding dbapi because it is more like a shared integration between instrumentors for concrete db drivers.

Describe alternatives you've considered

No response

Additional Context

No response

Would you like to implement a fix?

None

@beijiez
Copy link
Contributor

beijiez commented Dec 13, 2024

Hey! Great issue. I'd like to take this on

@tammy-baylis-swi
Copy link
Contributor Author

Thanks @beijiez for volunteering! Assigned to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants