Skip to content

Starlette instrumentation tests fail recent versions starlette >= 0.15.0 #3317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aabmass opened this issue Feb 28, 2025 · 3 comments
Open
Labels
bug Something isn't working instrumentation

Comments

@aabmass
Copy link
Member

aabmass commented Feb 28, 2025

Originally posted by @aabmass in #3304 (comment)

Only really ancient versions of starlette seem to be working with opentelemetry-insturmentation-starlette. The tests fail if you increase the version range because of an issue with capturing custom headers. See thread for more context.

@Kludex
Copy link
Contributor

Kludex commented Feb 28, 2025

The reason is that we adopted anyio in Starlette on that version.

That said, I don't think it makes sense to maintain <0.15, nor anything close to that. 0.15.0 is from June 23, 2021. In the ASGI ecosystem, that is pretty old already.

@aabmass
Copy link
Member Author

aabmass commented Mar 3, 2025

I agree we should increase the minimum version. Is this something you'd be willing to work on?

@Kludex
Copy link
Contributor

Kludex commented Mar 4, 2025

I don't think I'll have time soon. If someone else wants to try, I can review it. Otherwise, we can wait till I have a bit more time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working instrumentation
Projects
None yet
Development

No branches or pull requests

2 participants