Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate None token passed to context.detach #3351

Open
xrmx opened this issue Mar 10, 2025 · 3 comments
Open

Evaluate None token passed to context.detach #3351

xrmx opened this issue Mar 10, 2025 · 3 comments
Labels
bug Something isn't working

Comments

@xrmx
Copy link
Contributor

xrmx commented Mar 10, 2025

Evaluate the users of the context api to check that the callers of the detach function are passing a token that is not None.
This can be checked by inspection or by throwing pyright at the instrumentation code and stasrt fixing any typing issue.

For finding entries search for detach(token)

@xrmx xrmx added the bug Something isn't working label Mar 10, 2025
@aryabharat
Copy link
Contributor

@xrmx can i pick this ?

@xrmx
Copy link
Contributor Author

xrmx commented Mar 31, 2025

@aryabharat When you are ready to work on this just state so in a comment and we'll consider this assigned to you for one week.

@aryabharat
Copy link
Contributor

aryabharat commented Mar 31, 2025

@xrmx sure.
Should we handle the None check wherever context.detach() is called?"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants