Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate README.rst files at PR time #3364

Open
xrmx opened this issue Mar 13, 2025 · 5 comments
Open

Validate README.rst files at PR time #3364

xrmx opened this issue Mar 13, 2025 · 5 comments

Comments

@xrmx
Copy link
Contributor

xrmx commented Mar 13, 2025

README.rst files are used for package description and are validated when uploading to pypi. If the README.rst is invalid the upload would fail as will do the release workflow. Since we can catch invalid READMEs earlier it would be nice to do that and avoid a cause of stress at release time.

@xrmx
Copy link
Contributor Author

xrmx commented Mar 13, 2025

Looks like something like this may work:

pip install rstcheck

rstcheck --report warning --recursive instrumentation instrumentation-genai/ exporter opentelemetry-instrumentation/ util processor/ propagator opentelemetry-distro

@emdneto
Copy link
Member

emdneto commented Mar 13, 2025

@xrmx rstcheck has pre-commit action, so we can use it I guess

@emdneto
Copy link
Member

emdneto commented Mar 13, 2025

  - repo: https://github.com/rstcheck/rstcheck
    rev: f30c4d170a36ea3812bceb5f33004afc213bd797 # frozen: v6.2.4
    hooks:
      - id: rstcheck
        additional_dependencies: [sphinx]
        exclude: testing

@Binita-16
Copy link

Can you please assign this to me, if not already solved

@xrmx
Copy link
Contributor Author

xrmx commented Mar 25, 2025

@Binita-16 If you have time to work on this just add a comment here and we'll consider the issue assigned to you for a week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants