Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up from pull request #3400 for Google Gen AI code #3407

Open
michaelsafyan opened this issue Apr 3, 2025 · 4 comments
Open

Follow up from pull request #3400 for Google Gen AI code #3407

michaelsafyan opened this issue Apr 3, 2025 · 4 comments
Assignees

Comments

@michaelsafyan
Copy link
Contributor

The pull request https://github.com/open-telemetry/opentelemetry-python-contrib/pull/3400/files was merged with some unaddressed items for Google Gen AI:

  1. Correctly document metrics as supported
  2. Use a single source of truth for the version of google-genai that is instrumented
@michaelsafyan
Copy link
Contributor Author

Please assign to me (I'm not able to edit assignees). Created this for tracking purposes to not forget.

@emdneto
Copy link
Member

emdneto commented Apr 3, 2025

@michaelsafyan I would also add that google-genai package is missing the trove classifier for Python 3.8, 3.9 and 3.13 in pyproject.toml

@michaelsafyan
Copy link
Contributor Author

Thanks. Will look into it.

@xrmx
Copy link
Contributor

xrmx commented Apr 4, 2025

FYI you have already two sources of truth in the code, in instrumentor.py please use _instruments from package.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants