Skip to content

opentelemetry-instrument 0.53b0 release breaks azure-monitor-opentelemetry #3415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
batiste opened this issue Apr 10, 2025 · 18 comments · May be fixed by #3418
Open

opentelemetry-instrument 0.53b0 release breaks azure-monitor-opentelemetry #3415

batiste opened this issue Apr 10, 2025 · 18 comments · May be fixed by #3418
Labels
bug Something isn't working

Comments

@batiste
Copy link

batiste commented Apr 10, 2025

Describe your environment

On a Github workflow, I run mypy on my code base

repos:
- repo: https://github.com/astral-sh/ruff-pre-commit
  # Ruff version.
  rev: v0.6.9
  hooks:
    # Run the linter.
    - id: ruff
      args: [ --fix ]
    # Run the formatter.
    - id: ruff-format

-   repo: https://github.com/pre-commit/mirrors-mypy
    rev: 'v1.12.0'  # Use the sha / tag you want to point at
    hooks:
    -   id: mypy
        args: [--config-file=backend/setup.cfg]
        # exclude: "[a-zA-Z]*/(migrations)/(.)*"
        additional_dependencies:
          - 'django'
          - 'django-stubs'
          - 'django-ninja'
          - 'django-environ'
          - 'django-extensions'
          - 'psycopg2-binary'
          - 'pytest'
          - 'pyjwt'
          - 'opentelemetry-instrumentation-django'
          - 'opentelemetry-instrumentation-logging'
          - 'azure-monitor-opentelemetry'
          - 'daphne'
          - 'types-requests'
          - 'django-storages'
          - 'azure-storage-blob'
          - 'msgraph-sdk'
          - 'django-import-export'
          - 'atlassian-python-api'
          - 'django-json-widget'
          - 'django-pagedown'
          - 'django-markdown-deux'
          - 'jsonschema'
          - 'types-jsonschema'

What happened?

With the latest release I get this error:

  File "/home/runner/work/project-spike/project-spike/backend/project/settings/base.py", line 15, in <module>
    from azure.monitor.opentelemetry import configure_azure_monitor
  File "/home/runner/.cache/pre-commit/repoi8nrrfao/py_env-python3.12/lib/python3.12/site-packages/azure/monitor/opentelemetry/__init__.py", line 7, in <module>
    from azure.monitor.opentelemetry._configure import configure_azure_monitor
  File "/home/runner/.cache/pre-commit/repoi8nrrfao/py_env-python3.12/lib/python3.12/site-packages/azure/monitor/opentelemetry/_configure.py", line 12, in <module>
    from opentelemetry.instrumentation.dependencies import (
ImportError: cannot import name 'get_dist_dependency_conflicts' from 'opentelemetry.instrumentation.dependencies' (/home/runner/.cache/pre-commit/repoi8nrrfao/py_env-python3.12/lib/python3.12/site-packages/opentelemetry/instrumentation/dependencies.py). Did you mean: 'get_dependency_conflicts'?

Steps to Reproduce

Install mypy
Use the latest version (0.53b0) released on the 10th of Apr 2025

Expected Result

Should not error out

Actual Result

It errors

Additional context

No response

Would you like to implement a fix?

None

@batiste batiste added the bug Something isn't working label Apr 10, 2025
@johnrulon
Copy link

We are seeing the same breaking change with 'get_dist_dependency_conflicts' being removed.

@RobynG-0
Copy link

Same issue has broken azure-management-opentelemetry too

@Mdhvince
Copy link

Same here !!

@NahuelGrasso
Copy link

Same here!

@madhurimittal
Copy link

We have the same issue. It broke our Azure-Telemetry. Can this be fixed asap ?

@rafabandoni
Copy link

rafabandoni commented Apr 10, 2025

Same issue here. Fixed with a workaround by freezing dependencies on the following versions:
azure-monitor-opentelemetry = "^1.6.6"
opentelemetry-instrumentation = "0.51b0"

@madhurimittal
Copy link

Same issue here. Fixed with a workaround by freezing dependencies on the following versions: azure-monitor-opentelemetry = "^1.6.6" opentelemetry-instrumentation = "0.51b0"

Hello @rafabandoni are these entries from requirements.txt ?

@rafabandoni
Copy link

rafabandoni commented Apr 10, 2025

Same issue here. Fixed with a workaround by freezing dependencies on the following versions: azure-monitor-opentelemetry = "^1.6.6" opentelemetry-instrumentation = "0.51b0"

Hello @rafabandoni are these entries from requirements.txt ?

Hello @madhurimittal ! No, sorry, we use poetry (pyproject.toml)
Maybe for requirements.txt you will need something like below:
azure-monitor-opentelemetry==1.6.6
opentelemetry-instrumentation==0.51b0

@madhurimittal
Copy link

Same issue here. Fixed with a workaround by freezing dependencies on the following versions: azure-monitor-opentelemetry = "^1.6.6" opentelemetry-instrumentation = "0.51b0"

Hello @rafabandoni are these entries from requirements.txt ?

Hello @madhurimittal ! No, sorry, we use poetry (pyproject.toml)

Thanks no worries

@Rexeh
Copy link

Rexeh commented Apr 10, 2025

Is this likely to be rolled back, or do we need to wait for a few fixes? Affected via azure-monitor-opentelemetry.

Cheers,

Rob

@xrmx xrmx changed the title 0.53b0 release breaks mypy opentelemetry-instrument 0.53b0 release breaks azure-opentelemetry Apr 10, 2025
@xrmx xrmx changed the title opentelemetry-instrument 0.53b0 release breaks azure-opentelemetry opentelemetry-instrument 0.53b0 release breaks azure-monitor-opentelemetry Apr 10, 2025
@aabmass
Copy link
Member

aabmass commented Apr 10, 2025

Thanks for the reports and sorry for the inconvenience. Looks like #3202 is the culprit.

Is this likely to be rolled back, or do we need to wait for a few fixes? Affected via azure-monitor-opentelemetry.

Please pin your version to the previous release, there's nothing we can really rollback.

@xrmx
Copy link
Contributor

xrmx commented Apr 10, 2025

You may want to follow:
Azure/azure-sdk-for-python#40465 (comment)

@aabmass
Copy link
Member

aabmass commented Apr 10, 2025

If you are calling get_dist_dependency_conflicts() directly, please drop a comment in this issue. I'm trying to gauge how many people are broken transitively through Azure SDK vs directly.

@neeagl
Copy link

neeagl commented Apr 10, 2025

Our deployment just got failed as well because of this update. On digging, it appears in the package: opentelemetry-instrumentation
Have pinned it to v0.52b1 and it worked!

@jeremydvoss
Copy link
Contributor

Fixed in azure-monitor-opentelemetry==1.6.7
When using 1.6.7, you can use OTel==1.32/0.53b0 successfully

@jeremydvoss
Copy link
Contributor

Recommend closing, but we can leave open for a bit in case anyone has questions.

@emdneto
Copy link
Member

emdneto commented Apr 10, 2025

@jeremydvoss I'll wait in #3418 then

@Montags24
Copy link

We had this break as well - just pinned previous release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet