Skip to content

[urllib] Replace span name callback with request and response hooks #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
owais opened this issue Apr 5, 2021 · 2 comments
Closed

[urllib] Replace span name callback with request and response hooks #412

owais opened this issue Apr 5, 2021 · 2 comments
Assignees
@ryokather
Labels
feature-request good first issue Good for newcomers

Comments

@owais
Copy link
Contributor

owais commented Apr 5, 2021

Urrllib instrumentation accepts a span name callback which should be replaced with more generic request/response callbacks (hooks).

Details: #408
@owais owais changed the title [urllib] Replace span name callback with request and response hooks #410 [urllib] Replace span name callback with request and response hooks Apr 5, 2021
@owais owais added the good first issue Good for newcomers label Apr 8, 2021
@ryokather
Copy link
Contributor

@owais I'd be happy to take this up and work on the remaining instrumentations that don't have request and response hooks implemented yet!

@ryokather ryokather mentioned this issue Jun 18, 2021
Closed
@ryokather ryokather mentioned this issue Jul 12, 2021
Merged
7 tasks
@lzchen
Copy link
Contributor

lzchen commented Sep 13, 2021

Finished with #576

@lzchen lzchen closed this as completed Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryokather ryokather

Labels
feature-request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@owais @lzchen @ryokather