Skip to content

Flask: Conditionally create SERVER spans #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
owais opened this issue Apr 15, 2021 · 6 comments · Fixed by #828
Closed

Flask: Conditionally create SERVER spans #446

owais opened this issue Apr 15, 2021 · 6 comments · Fixed by #828
Assignees

Comments

@owais
Copy link
Contributor

owais commented Apr 15, 2021

Part of #445

@owais owais added feature-request good first issue Good for newcomers help wanted Extra attention is needed instrumentation labels Apr 15, 2021
@pravarag
Copy link

pravarag commented Oct 3, 2021

@owais I would like to work on this issue as a beginner. Kindly let me know if it's okay to pick this issue or not 🙂

@owais owais removed the good first issue Good for newcomers label Oct 3, 2021
@owais
Copy link
Contributor Author

owais commented Oct 3, 2021

Hi @pravarag. Yes, you can pick it up but be warned that it might sound simpler than it is. We've had at least one other person attempt this only to find out it was more complicated than it looked :)

I don't want to discourage you but just trying to set the expectations. I've removed "good first issue" label from this ticket as it was a bit misleading I think.

All things considered, this is not a hard or complex issue but definitely not a byte-sized, beginner friendly problem either. Happy to assign it to you.

@pravarag
Copy link

pravarag commented Oct 3, 2021

Thanks @owais , if possible could you please help me in finding a beginner friendly issue to work on 🙂 , I'll be happy to take that.

@owais
Copy link
Contributor Author

owais commented Oct 3, 2021

good first issue Good for newcomers
https://github.com/open-telemetry/opentelemetry-python/labels/good%20first%20issue

@pravarag ^

@ashu658
Copy link
Member

ashu658 commented Nov 11, 2021

Hi @owais
I would like to work on this as my first issue! Can you assign this issue to me?
Would really appreciate any help in getting started with the same.

@owais
Copy link
Contributor Author

owais commented Nov 11, 2021

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants