-
Notifications
You must be signed in to change notification settings - Fork 684
FastAPI: Conditionally create SERVER spans #451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @owais : Can you please assign it to me? |
I can see that we already have resolved the same type of issue for ASGI in PR |
Can we add a test to FastAPI package to verify the behaviour so we catch any breakage in future? |
Test case has already been added as a part of the PR mentioned in above comment |
Oh nice! I thought it would contain test for ASGI package. Sounds good. I'll close this one but may be we should add a test case to ASGI package as well? |
Make sense. can you reopen the ASGI issue #455 so that I will raise a PR for the same to add a test case? |
The issue has been resolved already. You can open a new issue or just submit a PR without an issue if you'd like. |
Part of #445
The text was updated successfully, but these errors were encountered: