Skip to content

Starlet: Conditionally create SERVER spans #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
owais opened this issue Apr 15, 2021 · 2 comments · Fixed by #897
Closed

Starlet: Conditionally create SERVER spans #452

owais opened this issue Apr 15, 2021 · 2 comments · Fixed by #897
Assignees
@ashu658
Labels
feature-request help wanted Extra attention is needed instrumentation

Comments

@owais
Copy link
Contributor

owais commented Apr 15, 2021

Part of #445
@owais owais added feature-request good first issue Good for newcomers help wanted Extra attention is needed instrumentation labels Apr 15, 2021
@codeboten codeboten mentioned this issue Apr 15, 2021
Closed
@owais owais removed the good first issue Good for newcomers label Oct 3, 2021
@ashu658
Copy link
Member

ashu658 commented Feb 3, 2022

@owais please assign this issue to me.

@ashu658 ashu658 mentioned this issue Feb 3, 2022
Merged
4 tasks
@ashu658
Copy link
Member

ashu658 commented Feb 3, 2022

Starlette uses asgi middleware which already has the changes required for conditional server span creation. I have added unit tests for starlette.

@owais owais closed this as completed in #897 Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ashu658 ashu658

Labels
feature-request help wanted Extra attention is needed instrumentation
Projects
None yet
Milestone
No milestone
2 participants
@owais @ashu658