Skip to content

Commit 04361b3

Browse files
authored
Merge branch 'main' into issue_2755
2 parents 4cbd7ff + 25771ec commit 04361b3

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

opentelemetry-sdk/src/opentelemetry/sdk/util/instrumentation.py

+4
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,8 @@ def __init__(
3535
):
3636
self._name = name
3737
self._version = version
38+
if schema_url is None:
39+
schema_url = ""
3840
self._schema_url = schema_url
3941

4042
def __repr__(self):
@@ -90,6 +92,8 @@ def __init__(
9092
) -> None:
9193
self._name = name
9294
self._version = version
95+
if schema_url is None:
96+
schema_url = ""
9397
self._schema_url = schema_url
9498

9599
def __repr__(self) -> str:

opentelemetry-sdk/tests/trace/test_trace.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -271,7 +271,7 @@ def test_invalid_instrumentation_info(self):
271271
)
272272
span1 = tracer1.start_span("foo")
273273
self.assertTrue(span1.is_recording())
274-
self.assertEqual(tracer1.instrumentation_info.schema_url, None)
274+
self.assertEqual(tracer1.instrumentation_info.schema_url, "")
275275
self.assertEqual(tracer1.instrumentation_info.version, "")
276276
self.assertEqual(tracer1.instrumentation_info.name, "")
277277

@@ -280,7 +280,7 @@ def test_invalid_instrumentation_info(self):
280280
)
281281
span2 = tracer2.start_span("bar")
282282
self.assertTrue(span2.is_recording())
283-
self.assertEqual(tracer2.instrumentation_info.schema_url, None)
283+
self.assertEqual(tracer2.instrumentation_info.schema_url, "")
284284
self.assertEqual(tracer2.instrumentation_info.version, "")
285285
self.assertEqual(tracer2.instrumentation_info.name, "")
286286

0 commit comments

Comments
 (0)