Skip to content

Commit 0cd439f

Browse files
author
Alex Boten
committed
move logs to _logs (#2240)
* move logs to _logs * fix lint
1 parent 24b5517 commit 0cd439f

File tree

15 files changed

+46
-44
lines changed

15 files changed

+46
-44
lines changed

docs/examples/logs/example.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,12 @@
22

33
from opentelemetry import trace
44
from opentelemetry.exporter.otlp.proto.grpc.log_exporter import OTLPLogExporter
5-
from opentelemetry.sdk.logs import (
5+
from opentelemetry.sdk._logs import (
66
LogEmitterProvider,
77
OTLPHandler,
88
set_log_emitter_provider,
99
)
10-
from opentelemetry.sdk.logs.export import BatchLogProcessor
10+
from opentelemetry.sdk._logs.export import BatchLogProcessor
1111
from opentelemetry.sdk.resources import Resource
1212
from opentelemetry.sdk.trace import TracerProvider
1313
from opentelemetry.sdk.trace.export import (

docs/sdk/logs.export.rst

+4-4
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
opentelemetry.sdk.logs.export
2-
=============================
1+
opentelemetry.sdk._logs.export
2+
==============================
33

4-
.. automodule:: opentelemetry.sdk.logs.export
4+
.. automodule:: opentelemetry.sdk._logs.export
55
:members:
66
:undoc-members:
7-
:show-inheritance:
7+
:show-inheritance:

docs/sdk/logs.rst

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
opentelemetry.sdk.logs package
1+
opentelemetry.sdk._logs package
22
===============================
33

44
Submodules
@@ -9,7 +9,7 @@ Submodules
99
logs.export
1010
logs.severity
1111

12-
.. automodule:: opentelemetry.sdk.logs
12+
.. automodule:: opentelemetry.sdk._logs
1313
:members:
1414
:undoc-members:
1515
:show-inheritance:

docs/sdk/logs.severity.rst

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
opentelemetry.sdk.logs.severity
2-
===============================
1+
opentelemetry.sdk._logs.severity
2+
================================
33

4-
.. automodule:: opentelemetry.sdk.logs.severity
4+
.. automodule:: opentelemetry.sdk._logs.severity
55
:members:
66
:undoc-members:
77
:show-inheritance:

exporter/opentelemetry-exporter-otlp-proto-grpc/src/opentelemetry/exporter/otlp/proto/grpc/log_exporter/__init__.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,9 @@
3131
ResourceLogs,
3232
)
3333
from opentelemetry.proto.logs.v1.logs_pb2 import LogRecord as PB2LogRecord
34-
from opentelemetry.sdk.logs import LogRecord as SDKLogRecord
35-
from opentelemetry.sdk.logs import LogData
36-
from opentelemetry.sdk.logs.export import LogExporter, LogExportResult
34+
from opentelemetry.sdk._logs import LogRecord as SDKLogRecord
35+
from opentelemetry.sdk._logs import LogData
36+
from opentelemetry.sdk._logs.export import LogExporter, LogExportResult
3737

3838

3939
class OTLPLogExporter(

exporter/opentelemetry-exporter-otlp-proto-grpc/tests/logs/test_otlp_logs_exporter.py

+5-3
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,11 @@
4242
from opentelemetry.proto.resource.v1.resource_pb2 import (
4343
Resource as OTLPResource,
4444
)
45-
from opentelemetry.sdk.logs import LogData, LogRecord
46-
from opentelemetry.sdk.logs.export import LogExportResult
47-
from opentelemetry.sdk.logs.severity import SeverityNumber as SDKSeverityNumber
45+
from opentelemetry.sdk._logs import LogData, LogRecord
46+
from opentelemetry.sdk._logs.export import LogExportResult
47+
from opentelemetry.sdk._logs.severity import (
48+
SeverityNumber as SDKSeverityNumber,
49+
)
4850
from opentelemetry.sdk.resources import Resource as SDKResource
4951
from opentelemetry.sdk.util.instrumentation import InstrumentationInfo
5052
from opentelemetry.trace import TraceFlags

opentelemetry-sdk/setup.cfg

+1-1
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ opentelemetry_tracer_provider =
5555
opentelemetry_traces_exporter =
5656
console = opentelemetry.sdk.trace.export:ConsoleSpanExporter
5757
opentelemetry_log_emitter_provider =
58-
sdk_log_emitter_provider = opentelemetry.sdk.logs:LogEmitterProvider
58+
sdk_log_emitter_provider = opentelemetry.sdk._logs:LogEmitterProvider
5959
opentelemetry_id_generator =
6060
random = opentelemetry.sdk.trace.id_generator:RandomIdGenerator
6161
opentelemetry_environment_variables =

opentelemetry-sdk/src/opentelemetry/sdk/logs/__init__.py renamed to opentelemetry-sdk/src/opentelemetry/sdk/_logs/__init__.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,10 @@
2121
import threading
2222
from typing import Any, Callable, Optional, Tuple, Union, cast
2323

24+
from opentelemetry.sdk._logs.severity import SeverityNumber, std_to_otlp
2425
from opentelemetry.sdk.environment_variables import (
2526
OTEL_PYTHON_LOG_EMITTER_PROVIDER,
2627
)
27-
from opentelemetry.sdk.logs.severity import SeverityNumber, std_to_otlp
2828
from opentelemetry.sdk.resources import Resource
2929
from opentelemetry.sdk.util import ns_to_iso_str
3030
from opentelemetry.sdk.util.instrumentation import InstrumentationInfo
@@ -124,7 +124,7 @@ def emit(self, log_data: LogData):
124124

125125
@abc.abstractmethod
126126
def shutdown(self):
127-
"""Called when a :class:`opentelemetry.sdk.logs.LogEmitter` is shutdown"""
127+
"""Called when a :class:`opentelemetry.sdk._logs.LogEmitter` is shutdown"""
128128

129129
@abc.abstractmethod
130130
def force_flush(self, timeout_millis: int = 30000):
@@ -489,7 +489,7 @@ def get_log_emitter(
489489
"""Returns a `LogEmitter` for use within a python process.
490490
491491
This function is a convenience wrapper for
492-
opentelemetry.sdk.logs.LogEmitterProvider.get_log_emitter.
492+
opentelemetry.sdk._logs.LogEmitterProvider.get_log_emitter.
493493
494494
If log_emitter_provider param is omitted the current configured one is used.
495495
"""

opentelemetry-sdk/src/opentelemetry/sdk/logs/export/__init__.py renamed to opentelemetry-sdk/src/opentelemetry/sdk/_logs/export/__init__.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
from typing import IO, Callable, Deque, List, Optional, Sequence
2323

2424
from opentelemetry.context import attach, detach, set_value
25-
from opentelemetry.sdk.logs import LogData, LogProcessor, LogRecord
25+
from opentelemetry.sdk._logs import LogData, LogProcessor, LogRecord
2626
from opentelemetry.util._time import _time_ns
2727

2828
_logger = logging.getLogger(__name__)
@@ -39,7 +39,7 @@ class LogExporter(abc.ABC):
3939
Interface to be implemented by services that want to export logs received
4040
in their own format.
4141
42-
To export data this MUST be registered to the :class`opentelemetry.sdk.logs.LogEmitter` using a
42+
To export data this MUST be registered to the :class`opentelemetry.sdk._logs.LogEmitter` using a
4343
log processor.
4444
"""
4545

opentelemetry-sdk/src/opentelemetry/sdk/logs/export/in_memory_log_exporter.py renamed to opentelemetry-sdk/src/opentelemetry/sdk/_logs/export/in_memory_log_exporter.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515
import threading
1616
import typing
1717

18-
from opentelemetry.sdk.logs import LogData
19-
from opentelemetry.sdk.logs.export import LogExporter, LogExportResult
18+
from opentelemetry.sdk._logs import LogData
19+
from opentelemetry.sdk._logs.export import LogExporter, LogExportResult
2020

2121

2222
class InMemoryLogExporter(LogExporter):

opentelemetry-sdk/tests/logs/test_export.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -21,21 +21,21 @@
2121
from unittest.mock import Mock, patch
2222

2323
from opentelemetry.sdk import trace
24-
from opentelemetry.sdk.logs import (
24+
from opentelemetry.sdk._logs import (
2525
LogData,
2626
LogEmitterProvider,
2727
LogRecord,
2828
OTLPHandler,
2929
)
30-
from opentelemetry.sdk.logs.export import (
30+
from opentelemetry.sdk._logs.export import (
3131
BatchLogProcessor,
3232
ConsoleExporter,
3333
SimpleLogProcessor,
3434
)
35-
from opentelemetry.sdk.logs.export.in_memory_log_exporter import (
35+
from opentelemetry.sdk._logs.export.in_memory_log_exporter import (
3636
InMemoryLogExporter,
3737
)
38-
from opentelemetry.sdk.logs.severity import SeverityNumber
38+
from opentelemetry.sdk._logs.severity import SeverityNumber
3939
from opentelemetry.sdk.resources import Resource as SDKResource
4040
from opentelemetry.sdk.util.instrumentation import InstrumentationInfo
4141
from opentelemetry.trace import TraceFlags

opentelemetry-sdk/tests/logs/test_global_provider.py

+11-11
Original file line numberDiff line numberDiff line change
@@ -18,20 +18,20 @@
1818
from logging import WARNING
1919
from unittest.mock import patch
2020

21-
from opentelemetry.sdk import logs
22-
from opentelemetry.sdk.environment_variables import (
23-
OTEL_PYTHON_LOG_EMITTER_PROVIDER,
24-
)
25-
from opentelemetry.sdk.logs import (
21+
from opentelemetry.sdk import _logs
22+
from opentelemetry.sdk._logs import (
2623
LogEmitterProvider,
2724
get_log_emitter_provider,
2825
set_log_emitter_provider,
2926
)
27+
from opentelemetry.sdk.environment_variables import (
28+
OTEL_PYTHON_LOG_EMITTER_PROVIDER,
29+
)
3030

3131

3232
class TestGlobals(unittest.TestCase):
3333
def tearDown(self):
34-
reload(logs)
34+
reload(_logs)
3535

3636
def check_override_not_allowed(self):
3737
"""set_log_emitter_provider should throw a warning when overridden"""
@@ -42,34 +42,34 @@ def check_override_not_allowed(self):
4242
test.output,
4343
[
4444
(
45-
"WARNING:opentelemetry.sdk.logs:Overriding of current "
45+
"WARNING:opentelemetry.sdk._logs:Overriding of current "
4646
"LogEmitterProvider is not allowed"
4747
)
4848
],
4949
)
5050
self.assertIs(provider, get_log_emitter_provider())
5151

5252
def test_set_tracer_provider(self):
53-
reload(logs)
53+
reload(_logs)
5454
provider = LogEmitterProvider()
5555
set_log_emitter_provider(provider)
5656
retrieved_provider = get_log_emitter_provider()
5757
self.assertEqual(provider, retrieved_provider)
5858

5959
def test_tracer_provider_override_warning(self):
60-
reload(logs)
60+
reload(_logs)
6161
self.check_override_not_allowed()
6262

6363
@patch.dict(
6464
"os.environ",
6565
{OTEL_PYTHON_LOG_EMITTER_PROVIDER: "sdk_log_emitter_provider"},
6666
)
6767
def test_sdk_log_emitter_provider(self):
68-
reload(logs)
68+
reload(_logs)
6969
self.check_override_not_allowed()
7070

7171
@patch.dict("os.environ", {OTEL_PYTHON_LOG_EMITTER_PROVIDER: "unknown"})
7272
def test_unknown_log_emitter_provider(self):
73-
reload(logs)
73+
reload(_logs)
7474
with self.assertRaises(Exception):
7575
get_log_emitter_provider()

opentelemetry-sdk/tests/logs/test_handler.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@
1717
from unittest.mock import Mock
1818

1919
from opentelemetry.sdk import trace
20-
from opentelemetry.sdk.logs import LogEmitter, OTLPHandler
21-
from opentelemetry.sdk.logs.severity import SeverityNumber
20+
from opentelemetry.sdk._logs import LogEmitter, OTLPHandler
21+
from opentelemetry.sdk._logs.severity import SeverityNumber
2222
from opentelemetry.trace import INVALID_SPAN_CONTEXT
2323

2424

opentelemetry-sdk/tests/logs/test_multi_log_prcessor.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -21,15 +21,15 @@
2121
from abc import ABC, abstractmethod
2222
from unittest.mock import Mock
2323

24-
from opentelemetry.sdk.logs import (
24+
from opentelemetry.sdk._logs import (
2525
ConcurrentMultiLogProcessor,
2626
LogEmitterProvider,
2727
LogProcessor,
2828
LogRecord,
2929
OTLPHandler,
3030
SynchronousMultiLogProcessor,
3131
)
32-
from opentelemetry.sdk.logs.severity import SeverityNumber
32+
from opentelemetry.sdk._logs.severity import SeverityNumber
3333

3434

3535
class AnotherLogProcessor(LogProcessor):

0 commit comments

Comments
 (0)