Skip to content

Commit 1a95608

Browse files
authored
Merge branch 'main' into histogram-advisory
2 parents d4dc7c6 + 7ff2f51 commit 1a95608

File tree

4 files changed

+6
-8
lines changed

4 files changed

+6
-8
lines changed

CHANGELOG.md

+3
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1919
([#4389](https://github.com/open-telemetry/opentelemetry-python/pull/4389))
2020
- Add support for `explicit_bucket_boundaries` advisory for Histograms
2121
([#4361](https://github.com/open-telemetry/opentelemetry-python/pull/4361))
22+
- [BREAKING] semantic-conventions: Remove `opentelemetry.semconv.attributes.network_attributes.NETWORK_INTERFACE_NAME`
23+
introduced by mistake in the wrong module.
24+
([#4391](https://github.com/open-telemetry/opentelemetry-python/pull/4391))
2225

2326
## Version 1.29.0/0.50b0 (2024-12-11)
2427

opentelemetry-semantic-conventions/src/opentelemetry/semconv/_incubating/metrics/hw_metrics.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ def create_hw_power(
9898
Operational status: `1` (true) or `0` (false) for each of the possible states
9999
Instrument: updowncounter
100100
Unit: 1
101-
Note: `hw.status` is currently specified as an *UpDownCounter* but would ideally be represented using a [*StateSet* as defined in OpenMetrics](https://github.com/prometheus/OpenMetrics/blob/v1.0.0/specification/OpenMetrics.md#stateset). This semantic convention will be updated once *StateSet* is specified in OpenTelemetry. This planned change is not expected to have any consequence on the way users query their timeseries backend to retrieve the values of `hw.status` over time.
101+
Note: `hw.status` is currently specified as an *UpDownCounter* but would ideally be represented using a [*StateSet* as defined in OpenMetrics](https://github.com/OpenObservability/OpenMetrics/blob/main/specification/OpenMetrics.md#stateset). This semantic convention will be updated once *StateSet* is specified in OpenTelemetry. This planned change is not expected to have any consequence on the way users query their timeseries backend to retrieve the values of `hw.status` over time.
102102
"""
103103

104104

opentelemetry-semantic-conventions/src/opentelemetry/semconv/attributes/network_attributes.py

-5
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,6 @@
1515
from enum import Enum
1616
from typing import Final
1717

18-
NETWORK_INTERFACE_NAME: Final = "network.interface.name"
19-
"""
20-
The network interface name.
21-
"""
22-
2318
NETWORK_LOCAL_ADDRESS: Final = "network.local.address"
2419
"""
2520
Local address of the network connection - IP address or Unix domain socket name.

scripts/semconv/templates/registry/weaver.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ templates:
1313
filter: >
1414
semconv_grouped_attributes({
1515
"exclude_root_namespace": $excluded_namespaces,
16-
"exclude_stability": if $filter == "any" then [] else ["experimental"] end,
16+
"exclude_stability": if $filter == "any" then [] else ["experimental", "", null] end,
1717
})
1818
| map({
1919
root_namespace: .root_namespace,
@@ -28,7 +28,7 @@ templates:
2828
filter: >
2929
semconv_grouped_metrics({
3030
"exclude_root_namespace": $excluded_namespaces,
31-
"exclude_stability": if $filter == "any" then [] else ["experimental"] end,
31+
"exclude_stability": if $filter == "any" then [] else ["experimental", "", null] end,
3232
})
3333
| map({
3434
root_namespace: .root_namespace,

0 commit comments

Comments
 (0)