Skip to content

Commit 3143a4b

Browse files
Change default Sampler to ParentOrElse(AlwaysOn) (#960)
1 parent 6e34dfe commit 3143a4b

File tree

3 files changed

+3
-1
lines changed

3 files changed

+3
-1
lines changed

opentelemetry-sdk/CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
## Unreleased
44

5+
- Changed default Sampler to `ParentOrElse(AlwaysOn)`
56
- Update environment variable names, prefix changed from `OPENTELEMETRY` to `OTEL`
67
([#904](https://github.com/open-telemetry/opentelemetry-python/pull/904))
78
- Implement Views in metrics SDK

opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -859,7 +859,7 @@ def use_span(
859859
class TracerProvider(trace_api.TracerProvider):
860860
def __init__(
861861
self,
862-
sampler: sampling.Sampler = trace_api.sampling.ALWAYS_ON,
862+
sampler: sampling.Sampler = trace_api.sampling.DEFAULT_ON,
863863
resource: Resource = Resource.create_empty(),
864864
shutdown_on_exit: bool = True,
865865
active_span_processor: Union[

opentelemetry-sdk/tests/trace/test_trace.py

+1
Original file line numberDiff line numberDiff line change
@@ -344,6 +344,7 @@ def test_start_as_current_span_explicit(self):
344344
trace_id=0x000000000000000000000000DEADBEEF,
345345
span_id=0x00000000DEADBEF0,
346346
is_remote=False,
347+
trace_flags=trace_api.TraceFlags(trace_api.TraceFlags.SAMPLED),
347348
)
348349

349350
self.assertEqual(trace_api.get_current_span(), trace_api.INVALID_SPAN)

0 commit comments

Comments
 (0)