Skip to content

Commit 33879d4

Browse files
committed
Update tests to use new ids generator
1 parent b31828b commit 33879d4

File tree

4 files changed

+30
-18
lines changed

4 files changed

+30
-18
lines changed

docs/examples/opentelemetry-example-app/tests/test_flask_example.py

+3-2
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,8 @@ def tearDown(self):
4646
self.send_patcher.stop()
4747

4848
def test_full_path(self):
49-
trace_id = trace_sdk.generate_trace_id()
49+
ids_generator = trace.RandomIdsGenerator()
50+
trace_id = ids_generator.generate_trace_id()
5051
# We need to use the Werkzeug test app because
5152
# The headers are injected at the wsgi layer.
5253
# The flask test app will not include these, and
@@ -58,7 +59,7 @@ def test_full_path(self):
5859
headers={
5960
"traceparent": "00-{:032x}-{:016x}-{:02x}".format(
6061
trace_id,
61-
trace_sdk.generate_span_id(),
62+
ids_generator.generate_span_id(),
6263
trace.TraceFlags.SAMPLED,
6364
)
6465
},

exporter/opentelemetry-exporter-datadog/tests/test_datadog_format.py

+5-4
Original file line numberDiff line numberDiff line change
@@ -30,11 +30,12 @@ def get_as_list(dict_object, key):
3030
class TestDatadogFormat(unittest.TestCase):
3131
@classmethod
3232
def setUpClass(cls):
33+
ids_generator = trace_api.RandomIdsGenerator()
3334
cls.serialized_trace_id = propagator.format_trace_id(
34-
trace.generate_trace_id()
35+
ids_generator.generate_trace_id()
3536
)
3637
cls.serialized_parent_id = propagator.format_span_id(
37-
trace.generate_span_id()
38+
ids_generator.generate_span_id()
3839
)
3940
cls.serialized_origin = "origin-service"
4041

@@ -107,7 +108,7 @@ def test_context_propagation(self):
107108
"child",
108109
trace_api.SpanContext(
109110
parent_context.trace_id,
110-
trace.generate_span_id(),
111+
trace_api.RandomIdsGenerator().generate_span_id(),
111112
is_remote=False,
112113
trace_flags=parent_context.trace_flags,
113114
trace_state=parent_context.trace_state,
@@ -152,7 +153,7 @@ def test_sampling_priority_auto_reject(self):
152153
"child",
153154
trace_api.SpanContext(
154155
parent_context.trace_id,
155-
trace.generate_span_id(),
156+
trace_api.RandomIdsGenerator().generate_span_id(),
156157
is_remote=False,
157158
trace_flags=parent_context.trace_flags,
158159
trace_state=parent_context.trace_state,

opentelemetry-sdk/tests/trace/propagation/test_b3_format.py

+17-8
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ def get_child_parent_new_carrier(old_carrier):
3838
"child",
3939
trace_api.SpanContext(
4040
parent_context.trace_id,
41-
trace.generate_span_id(),
41+
trace_api.RandomIdsGenerator().generate_span_id(),
4242
is_remote=False,
4343
trace_flags=parent_context.trace_flags,
4444
trace_state=parent_context.trace_state,
@@ -56,14 +56,15 @@ def get_child_parent_new_carrier(old_carrier):
5656
class TestB3Format(unittest.TestCase):
5757
@classmethod
5858
def setUpClass(cls):
59+
ids_generator = trace_api.RandomIdsGenerator()
5960
cls.serialized_trace_id = b3_format.format_trace_id(
60-
trace.generate_trace_id()
61+
ids_generator.generate_trace_id()
6162
)
6263
cls.serialized_span_id = b3_format.format_span_id(
63-
trace.generate_span_id()
64+
ids_generator.generate_span_id()
6465
)
6566
cls.serialized_parent_id = b3_format.format_span_id(
66-
trace.generate_span_id()
67+
ids_generator.generate_span_id()
6768
)
6869

6970
def test_extract_multi_header(self):
@@ -246,8 +247,12 @@ def test_missing_trace_id(self):
246247
span_context = trace_api.get_current_span(ctx).get_context()
247248
self.assertEqual(span_context.trace_id, trace_api.INVALID_TRACE_ID)
248249

249-
@patch("opentelemetry.sdk.trace.propagation.b3_format.generate_trace_id")
250-
@patch("opentelemetry.sdk.trace.propagation.b3_format.generate_span_id")
250+
@patch(
251+
"opentelemetry.sdk.trace.propagation.b3_format.RandomIdsGenerator.generate_trace_id"
252+
)
253+
@patch(
254+
"opentelemetry.sdk.trace.propagation.b3_format.RandomIdsGenerator.generate_span_id"
255+
)
251256
def test_invalid_trace_id(
252257
self, mock_generate_span_id, mock_generate_trace_id
253258
):
@@ -268,8 +273,12 @@ def test_invalid_trace_id(
268273
self.assertEqual(span_context.trace_id, 1)
269274
self.assertEqual(span_context.span_id, 2)
270275

271-
@patch("opentelemetry.sdk.trace.propagation.b3_format.generate_trace_id")
272-
@patch("opentelemetry.sdk.trace.propagation.b3_format.generate_span_id")
276+
@patch(
277+
"opentelemetry.sdk.trace.propagation.b3_format.RandomIdsGenerator.generate_trace_id"
278+
)
279+
@patch(
280+
"opentelemetry.sdk.trace.propagation.b3_format.RandomIdsGenerator.generate_span_id"
281+
)
273282
def test_invalid_span_id(
274283
self, mock_generate_span_id, mock_generate_trace_id
275284
):

opentelemetry-sdk/tests/trace/test_trace.py

+5-4
Original file line numberDiff line numberDiff line change
@@ -615,14 +615,15 @@ def test_invalid_event_attributes(self):
615615
self.assertEqual(root.events[3].attributes, {"attr2": (1, 2)})
616616

617617
def test_links(self):
618+
ids_generator = trace_api.RandomIdsGenerator()
618619
other_context1 = trace_api.SpanContext(
619-
trace_id=trace.generate_trace_id(),
620-
span_id=trace.generate_span_id(),
620+
trace_id=ids_generator.generate_trace_id(),
621+
span_id=ids_generator.generate_span_id(),
621622
is_remote=False,
622623
)
623624
other_context2 = trace_api.SpanContext(
624-
trace_id=trace.generate_trace_id(),
625-
span_id=trace.generate_span_id(),
625+
trace_id=ids_generator.generate_trace_id(),
626+
span_id=ids_generator.generate_span_id(),
626627
is_remote=False,
627628
)
628629

0 commit comments

Comments
 (0)