Skip to content

Commit 3923c4d

Browse files
Rename Record class in Metrics SDK to Accumulation to follow spec (#1373)
1 parent c4950a3 commit 3923c4d

File tree

3 files changed

+12
-11
lines changed

3 files changed

+12
-11
lines changed

opentelemetry-sdk/CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
([#1314](https://github.com/open-telemetry/opentelemetry-python/pull/1314))
99
- Update exception handling optional parameters, add escaped attribute to record_exception
1010
([#1365](https://github.com/open-telemetry/opentelemetry-python/pull/1365))
11+
- Rename Record in Metrics SDK to Accumulation ([#1373](https://github.com/open-telemetry/opentelemetry-python/pull/1373))
1112

1213
## Version 0.15b0
1314

opentelemetry-sdk/src/opentelemetry/sdk/metrics/__init__.py

+5-5
Original file line numberDiff line numberDiff line change
@@ -325,7 +325,7 @@ class ValueObserver(Observer, metrics_api.ValueObserver):
325325
"""See `opentelemetry.metrics.ValueObserver`."""
326326

327327

328-
class Record:
328+
class Accumulation:
329329
"""Container class used for processing in the `Processor`"""
330330

331331
def __init__(
@@ -382,10 +382,10 @@ def _collect_metrics(self) -> None:
382382
bound_instrument,
383383
) in metric.bound_instruments.items():
384384
for view_data in bound_instrument.view_datas:
385-
record = Record(
385+
accumulation = Accumulation(
386386
metric, view_data.labels, view_data.aggregator
387387
)
388-
self.processor.process(record)
388+
self.processor.process(accumulation)
389389

390390
if bound_instrument.ref_count() == 0:
391391
to_remove.append(labels)
@@ -404,8 +404,8 @@ def _collect_observers(self) -> None:
404404
continue
405405

406406
for labels, aggregator in observer.aggregators.items():
407-
record = Record(observer, labels, aggregator)
408-
self.processor.process(record)
407+
accumulation = Accumulation(observer, labels, aggregator)
408+
self.processor.process(accumulation)
409409

410410
def record_batch(
411411
self,

opentelemetry-sdk/tests/metrics/export/test_export.py

+6-6
Original file line numberDiff line numberDiff line change
@@ -139,8 +139,8 @@ def test_processor_process_exists(self):
139139
_batch_map[batch_key] = aggregator
140140
aggregator2.update(1.0)
141141
processor._batch_map = _batch_map
142-
record = metrics.Record(metric, labels, aggregator2)
143-
processor.process(record)
142+
accumulation = metrics.Accumulation(metric, labels, aggregator2)
143+
processor.process(accumulation)
144144
self.assertEqual(len(processor._batch_map), 1)
145145
self.assertIsNotNone(processor._batch_map.get(batch_key))
146146
self.assertEqual(processor._batch_map.get(batch_key).current, 0)
@@ -159,8 +159,8 @@ def test_processor_process_not_exists(self):
159159
batch_key = (metric, SumAggregator, tuple(), labels)
160160
aggregator.update(1.0)
161161
processor._batch_map = _batch_map
162-
record = metrics.Record(metric, labels, aggregator)
163-
processor.process(record)
162+
accumulation = metrics.Accumulation(metric, labels, aggregator)
163+
processor.process(accumulation)
164164
self.assertEqual(len(processor._batch_map), 1)
165165
self.assertIsNotNone(processor._batch_map.get(batch_key))
166166
self.assertEqual(processor._batch_map.get(batch_key).current, 0)
@@ -182,8 +182,8 @@ def test_processor_process_not_stateful(self):
182182
batch_key = (metric, SumAggregator, tuple(), labels)
183183
aggregator.update(1.0)
184184
processor._batch_map = _batch_map
185-
record = metrics.Record(metric, labels, aggregator)
186-
processor.process(record)
185+
accumulation = metrics.Accumulation(metric, labels, aggregator)
186+
processor.process(accumulation)
187187
self.assertEqual(len(processor._batch_map), 1)
188188
self.assertIsNotNone(processor._batch_map.get(batch_key))
189189
self.assertEqual(processor._batch_map.get(batch_key).current, 0)

0 commit comments

Comments
 (0)