Skip to content

Commit 5618966

Browse files
committed
bug fix, pass the lint check
1 parent fb5dff6 commit 5618966

File tree

1 file changed

+4
-7
lines changed

1 file changed

+4
-7
lines changed

opentelemetry-sdk/tests/trace/test_trace.py

+4-7
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,6 @@
6262
StatusCode,
6363
get_tracer,
6464
set_tracer_provider,
65-
span,
6665
)
6766

6867

@@ -2070,14 +2069,13 @@ class TestRandomIdGenerator(unittest.TestCase):
20702069

20712070
@patch(
20722071
"random.getrandbits",
2073-
side_effect=[span.INVALID_SPAN_ID, 0x00000000DEADBEF0],
2072+
side_effect=[trace_api.INVALID_SPAN_ID, 0x00000000DEADBEF0],
20742073
)
20752074
def test_generate_span_id_avoids_invalid(self, mock_getrandbits):
20762075
generator = RandomIdGenerator()
20772076
span_id = generator.generate_span_id()
20782077

2079-
self.assertNotEqual(span_id, span.INVALID_SPAN_ID)
2080-
self.assertGreater(span_id, span.INVALID_SPAN_ID)
2078+
self.assertGreater(span_id, trace_api.INVALID_SPAN_ID)
20812079
self.assertLessEqual(span_id, self._SPAN_ID_MAX_VALUE)
20822080
self.assertEqual(
20832081
mock_getrandbits.call_count, 2
@@ -2086,16 +2084,15 @@ def test_generate_span_id_avoids_invalid(self, mock_getrandbits):
20862084
@patch(
20872085
"random.getrandbits",
20882086
side_effect=[
2089-
span.INVALID_TRACE_ID,
2087+
trace_api.INVALID_TRACE_ID,
20902088
0x000000000000000000000000DEADBEEF,
20912089
],
20922090
)
20932091
def test_generate_trace_id_avoids_invalid(self, mock_getrandbits):
20942092
generator = RandomIdGenerator()
20952093
trace_id = generator.generate_trace_id()
20962094

2097-
self.assertNotEqual(trace_id, span.INVALID_TRACE_ID)
2098-
self.assertGreater(trace_id, span.INVALID_TRACE_ID)
2095+
self.assertGreater(trace_id, trace_api.INVALID_TRACE_ID)
20992096
self.assertLessEqual(trace_id, self._TRACE_ID_MAX_VALUE)
21002097
self.assertEqual(
21012098
mock_getrandbits.call_count, 2

0 commit comments

Comments
 (0)