Skip to content

Commit 56357cc

Browse files
committed
Add repeated instrument names for SDK as well
1 parent 268694b commit 56357cc

File tree

1 file changed

+26
-0
lines changed

1 file changed

+26
-0
lines changed

opentelemetry-sdk/tests/metrics/test_metrics.py

+26
Original file line numberDiff line numberDiff line change
@@ -249,6 +249,32 @@ class TestMeter(TestCase):
249249
def setUp(self):
250250
self.meter = Meter(Mock(), Mock())
251251

252+
def test_repeated_instrument_names(self):
253+
try:
254+
self.meter.create_counter("counter")
255+
self.meter.create_up_down_counter("up_down_counter")
256+
self.meter.create_observable_counter("observable_counter", Mock())
257+
self.meter.create_histogram("histogram")
258+
self.meter.create_observable_gauge("observable_gauge", Mock())
259+
self.meter.create_observable_up_down_counter(
260+
"observable_up_down_counter", Mock()
261+
)
262+
except Exception as error:
263+
self.fail(f"Unexpected exception raised {error}")
264+
265+
for instrument_name in [
266+
"counter",
267+
"up_down_counter",
268+
"observable_counter",
269+
"histogram",
270+
"observable_gauge",
271+
"observable_up_down_counter",
272+
]:
273+
with self.assertRaises(Exception):
274+
getattr(self.meter, f"create_{instrument_name}")(
275+
instrument_name
276+
)
277+
252278
def test_create_counter(self):
253279
counter = self.meter.create_counter(
254280
"name", unit="unit", description="description"

0 commit comments

Comments
 (0)