Skip to content

Commit 66e1fa0

Browse files
committed
Update tests to use new ids generator
1 parent e458a7b commit 66e1fa0

File tree

4 files changed

+34
-19
lines changed

4 files changed

+34
-19
lines changed

docs/examples/opentelemetry-example-app/tests/test_flask_example.py

+4-3
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121

2222
import opentelemetry_example_app.flask_example as flask_example
2323
from opentelemetry import trace
24-
from opentelemetry.sdk import trace as trace_sdk
24+
from opentelemetry.sdk.trace.random_ids_generator import RandomIdsGenerator
2525

2626

2727
class TestFlaskExample(unittest.TestCase):
@@ -46,7 +46,8 @@ def tearDown(self):
4646
self.send_patcher.stop()
4747

4848
def test_full_path(self):
49-
trace_id = trace_sdk.generate_trace_id()
49+
ids_generator = RandomIdsGenerator()
50+
trace_id = ids_generator.generate_trace_id()
5051
# We need to use the Werkzeug test app because
5152
# The headers are injected at the wsgi layer.
5253
# The flask test app will not include these, and
@@ -58,7 +59,7 @@ def test_full_path(self):
5859
headers={
5960
"traceparent": "00-{:032x}-{:016x}-{:02x}".format(
6061
trace_id,
61-
trace_sdk.generate_span_id(),
62+
ids_generator.generate_span_id(),
6263
trace.TraceFlags.SAMPLED,
6364
)
6465
},

exporter/opentelemetry-exporter-datadog/tests/test_datadog_format.py

+6-4
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
from opentelemetry import trace as trace_api
1818
from opentelemetry.exporter.datadog import constants, propagator
1919
from opentelemetry.sdk import trace
20+
from opentelemetry.sdk.trace.random_ids_generator import RandomIdsGenerator
2021
from opentelemetry.trace import get_current_span, set_span_in_context
2122

2223
FORMAT = propagator.DatadogFormat()
@@ -30,11 +31,12 @@ def get_as_list(dict_object, key):
3031
class TestDatadogFormat(unittest.TestCase):
3132
@classmethod
3233
def setUpClass(cls):
34+
ids_generator = RandomIdsGenerator()
3335
cls.serialized_trace_id = propagator.format_trace_id(
34-
trace.generate_trace_id()
36+
ids_generator.generate_trace_id()
3537
)
3638
cls.serialized_parent_id = propagator.format_span_id(
37-
trace.generate_span_id()
39+
ids_generator.generate_span_id()
3840
)
3941
cls.serialized_origin = "origin-service"
4042

@@ -107,7 +109,7 @@ def test_context_propagation(self):
107109
"child",
108110
trace_api.SpanContext(
109111
parent_context.trace_id,
110-
trace.generate_span_id(),
112+
RandomIdsGenerator().generate_span_id(),
111113
is_remote=False,
112114
trace_flags=parent_context.trace_flags,
113115
trace_state=parent_context.trace_state,
@@ -152,7 +154,7 @@ def test_sampling_priority_auto_reject(self):
152154
"child",
153155
trace_api.SpanContext(
154156
parent_context.trace_id,
155-
trace.generate_span_id(),
157+
RandomIdsGenerator().generate_span_id(),
156158
is_remote=False,
157159
trace_flags=parent_context.trace_flags,
158160
trace_state=parent_context.trace_state,

opentelemetry-sdk/tests/trace/propagation/test_b3_format.py

+18-8
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
import opentelemetry.sdk.trace.propagation.b3_format as b3_format
2020
import opentelemetry.trace as trace_api
2121
from opentelemetry.context import get_current
22+
from opentelemetry.sdk.trace.random_ids_generator import RandomIdsGenerator
2223

2324
FORMAT = b3_format.B3Format()
2425

@@ -38,7 +39,7 @@ def get_child_parent_new_carrier(old_carrier):
3839
"child",
3940
trace_api.SpanContext(
4041
parent_context.trace_id,
41-
trace.generate_span_id(),
42+
RandomIdsGenerator().generate_span_id(),
4243
is_remote=False,
4344
trace_flags=parent_context.trace_flags,
4445
trace_state=parent_context.trace_state,
@@ -56,14 +57,15 @@ def get_child_parent_new_carrier(old_carrier):
5657
class TestB3Format(unittest.TestCase):
5758
@classmethod
5859
def setUpClass(cls):
60+
ids_generator = RandomIdsGenerator()
5961
cls.serialized_trace_id = b3_format.format_trace_id(
60-
trace.generate_trace_id()
62+
ids_generator.generate_trace_id()
6163
)
6264
cls.serialized_span_id = b3_format.format_span_id(
63-
trace.generate_span_id()
65+
ids_generator.generate_span_id()
6466
)
6567
cls.serialized_parent_id = b3_format.format_span_id(
66-
trace.generate_span_id()
68+
ids_generator.generate_span_id()
6769
)
6870

6971
def test_extract_multi_header(self):
@@ -246,8 +248,12 @@ def test_missing_trace_id(self):
246248
span_context = trace_api.get_current_span(ctx).get_context()
247249
self.assertEqual(span_context.trace_id, trace_api.INVALID_TRACE_ID)
248250

249-
@patch("opentelemetry.sdk.trace.propagation.b3_format.generate_trace_id")
250-
@patch("opentelemetry.sdk.trace.propagation.b3_format.generate_span_id")
251+
@patch(
252+
"opentelemetry.sdk.trace.propagation.b3_format.RandomIdsGenerator.generate_trace_id"
253+
)
254+
@patch(
255+
"opentelemetry.sdk.trace.propagation.b3_format.RandomIdsGenerator.generate_span_id"
256+
)
251257
def test_invalid_trace_id(
252258
self, mock_generate_span_id, mock_generate_trace_id
253259
):
@@ -268,8 +274,12 @@ def test_invalid_trace_id(
268274
self.assertEqual(span_context.trace_id, 1)
269275
self.assertEqual(span_context.span_id, 2)
270276

271-
@patch("opentelemetry.sdk.trace.propagation.b3_format.generate_trace_id")
272-
@patch("opentelemetry.sdk.trace.propagation.b3_format.generate_span_id")
277+
@patch(
278+
"opentelemetry.sdk.trace.propagation.b3_format.RandomIdsGenerator.generate_trace_id"
279+
)
280+
@patch(
281+
"opentelemetry.sdk.trace.propagation.b3_format.RandomIdsGenerator.generate_span_id"
282+
)
273283
def test_invalid_span_id(
274284
self, mock_generate_span_id, mock_generate_trace_id
275285
):

opentelemetry-sdk/tests/trace/test_trace.py

+6-4
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
from opentelemetry import trace as trace_api
2222
from opentelemetry.sdk import resources, trace
2323
from opentelemetry.sdk.trace import Resource, sampling
24+
from opentelemetry.sdk.trace.random_ids_generator import RandomIdsGenerator
2425
from opentelemetry.sdk.util.instrumentation import InstrumentationInfo
2526
from opentelemetry.trace.status import StatusCanonicalCode
2627
from opentelemetry.util import time_ns
@@ -615,14 +616,15 @@ def test_invalid_event_attributes(self):
615616
self.assertEqual(root.events[3].attributes, {"attr2": (1, 2)})
616617

617618
def test_links(self):
619+
ids_generator = RandomIdsGenerator()
618620
other_context1 = trace_api.SpanContext(
619-
trace_id=trace.generate_trace_id(),
620-
span_id=trace.generate_span_id(),
621+
trace_id=ids_generator.generate_trace_id(),
622+
span_id=ids_generator.generate_span_id(),
621623
is_remote=False,
622624
)
623625
other_context2 = trace_api.SpanContext(
624-
trace_id=trace.generate_trace_id(),
625-
span_id=trace.generate_span_id(),
626+
trace_id=ids_generator.generate_trace_id(),
627+
span_id=ids_generator.generate_span_id(),
626628
is_remote=False,
627629
)
628630

0 commit comments

Comments
 (0)