Remove StatusError

Author: ocelotl

Diff for: opentelemetry-api/src/opentelemetry/trace/status.py

@@ -183,25 +183,3 @@ def description(self) -> typing.Optional[str]:
     def is_ok(self) -> bool:
         """Returns false if this represents an error, true otherwise."""
         return self._canonical_code is StatusCanonicalCode.OK
-
-
-class StatusError(Exception):
-    def __init__(
-        self,
-        canonical_code: StatusCanonicalCode,
-        description: typing.Optional[str] = None,
-    ):
-        self._canonical_code = canonical_code
-        self._description = description
-
-        super(StatusError, self).__init__()
-
-    @property
-    def canonical_code(self) -> StatusCanonicalCode:
-        """Represents the canonical status code of a finished Span."""
-        return self._canonical_code
-
-    @property
-    def description(self) -> typing.Optional[str]:
-        """Status description"""
-        return self._description

Diff for: opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py

@@ -26,7 +26,7 @@
 from opentelemetry.sdk import util
 from opentelemetry.sdk.util import BoundedDict, BoundedList
 from opentelemetry.trace import sampling
-from opentelemetry.trace.status import Status, StatusCanonicalCode, StatusError
+from opentelemetry.trace.status import Status, StatusCanonicalCode
 from opentelemetry.util import time_ns, types
 
 logger = logging.getLogger(__name__)
@@ -296,23 +296,14 @@ def __exit__(
         if self.status is None and self._auto_update_status:
             if exc_val is not None:
 
-                if isinstance(exc_val, StatusError):
-                    self.set_status(
-                        Status(
-                            canonical_code=exc_val.canonical_code,
-                            description=exc_val.description,
-                        )
-                    )
-
-                else:
-                    self.set_status(
-                        Status(
-                            canonical_code=StatusCanonicalCode.UNKNOWN,
-                            description="{}: {}".format(
-                                exc_type.__name__, exc_val
-                            ),
-                        )
+                self.set_status(
+                    Status(
+                        canonical_code=StatusCanonicalCode.UNKNOWN,
+                        description="{}: {}".format(
+                            exc_type.__name__, exc_val
+                        ),
                     )
+                )
 
         super().__exit__(exc_type, exc_val, exc_tb)
 

Diff for: opentelemetry-sdk/tests/trace/test_trace.py

@@ -20,7 +20,7 @@
 from opentelemetry import trace as trace_api
 from opentelemetry.sdk import trace
 from opentelemetry.trace import sampling
-from opentelemetry.trace.status import StatusCanonicalCode, StatusError
+from opentelemetry.trace.status import StatusCanonicalCode
 from opentelemetry.util import time_ns
 
 
@@ -514,14 +514,14 @@ def test_ended_span(self):
             self.assertIs(root.status, None)
 
     def test_error_status(self):
-        with self.assertRaises(StatusError):
+        try:
             with trace.Tracer("test_error_status").start_span("root") as root:
-                raise StatusError(StatusCanonicalCode.CANCELLED, "cancelled")
+                raise Exception("unknown")
+        except Exception:  # pylint: disable=broad-except
+            pass
 
-        self.assertIs(
-            root.status.canonical_code, StatusCanonicalCode.CANCELLED
-        )
-        self.assertEqual(root.status.description, "cancelled")
+        self.assertIs(root.status.canonical_code, StatusCanonicalCode.UNKNOWN)
+        self.assertEqual(root.status.description, "Exception: unknown")
 
 
 def span_event_start_fmt(span_processor_name, span_name):