File tree 3 files changed +17
-5
lines changed
src/opentelemetry/sdk/trace
3 files changed +17
-5
lines changed Original file line number Diff line number Diff line change @@ -6,6 +6,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
6
6
7
7
## [ Unreleased] ( https://github.com/open-telemetry/opentelemetry-python/compare/v1.2.0-0.21b0...HEAD )
8
8
9
+ ### Changed
10
+ - Updated get_tracer to return an empty string when passed an invalid name
11
+ ([ #1854 ] ( https://github.com/open-telemetry/opentelemetry-python/pull/1854 ) )
12
+
9
13
## [ 1.2.0, 0.21b0] ( https://github.com/open-telemetry/opentelemetry-python/releases/tag/v1.2.0-0.21b0 ) - 2021-05-11
10
14
11
15
### Added
Original file line number Diff line number Diff line change @@ -997,7 +997,7 @@ def get_tracer(
997
997
instrumenting_library_version : str = "" ,
998
998
) -> "trace_api.Tracer" :
999
999
if not instrumenting_module_name : # Reject empty strings too.
1000
- instrumenting_module_name = "ERROR:MISSING MODULE NAME "
1000
+ instrumenting_module_name = ""
1001
1001
logger .error ("get_tracer called with missing module name." )
1002
1002
return Tracer (
1003
1003
self .sampler ,
Original file line number Diff line number Diff line change @@ -257,17 +257,25 @@ def test_invalid_instrumentation_info(self):
257
257
tracer1 = tracer_provider .get_tracer ("" )
258
258
with self .assertLogs (level = ERROR ):
259
259
tracer2 = tracer_provider .get_tracer (None )
260
- self .assertEqual (
261
- tracer1 .instrumentation_info , tracer2 .instrumentation_info
262
- )
260
+
263
261
self .assertIsInstance (
264
262
tracer1 .instrumentation_info , InstrumentationInfo
265
263
)
266
264
span1 = tracer1 .start_span ("foo" )
267
265
self .assertTrue (span1 .is_recording ())
268
266
self .assertEqual (tracer1 .instrumentation_info .version , "" )
267
+ self .assertEqual (tracer1 .instrumentation_info .name , "" )
268
+
269
+ self .assertIsInstance (
270
+ tracer2 .instrumentation_info , InstrumentationInfo
271
+ )
272
+ span2 = tracer2 .start_span ("bar" )
273
+ self .assertTrue (span2 .is_recording ())
274
+ self .assertEqual (tracer2 .instrumentation_info .version , "" )
275
+ self .assertEqual (tracer2 .instrumentation_info .name , "" )
276
+
269
277
self .assertEqual (
270
- tracer1 .instrumentation_info . name , "ERROR:MISSING MODULE NAME"
278
+ tracer1 .instrumentation_info , tracer2 . instrumentation_info
271
279
)
272
280
273
281
def test_span_processor_for_source (self ):
You can’t perform that action at this time.
0 commit comments