Skip to content

Commit 82f841c

Browse files
committed
Exempt resource attributes from span limits
1 parent 8b5a967 commit 82f841c

File tree

3 files changed

+2
-6
lines changed

3 files changed

+2
-6
lines changed

CHANGELOG.md

+2
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1818
([#2101](https://github.com/open-telemetry/opentelemetry-python/pull/2101))
1919
- Fix incorrect headers parsing via environment variables
2020
([#2103](https://github.com/open-telemetry/opentelemetry-python/pull/2103))
21+
- Attribute limits no longer apply to Resource attributes
22+
([#2138](https://github.com/open-telemetry/opentelemetry-python/pull/2138))
2123

2224
## [1.5.0-0.24b0](https://github.com/open-telemetry/opentelemetry-python/releases/tag/v1.5.0-0.24b0) - 2021-08-26
2325

opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py

-5
Original file line numberDiff line numberDiff line change
@@ -1069,11 +1069,6 @@ def __init__(
10691069
self._span_limits = span_limits or SpanLimits()
10701070
self._atexit_handler = None
10711071

1072-
self._resource._attributes = BoundedAttributes(
1073-
self._span_limits.max_attributes,
1074-
self._resource._attributes,
1075-
max_value_len=self._span_limits.max_attribute_length,
1076-
)
10771072
if shutdown_on_exit:
10781073
self._atexit_handler = atexit.register(self.shutdown)
10791074

opentelemetry-sdk/tests/trace/test_trace.py

-1
Original file line numberDiff line numberDiff line change
@@ -1490,7 +1490,6 @@ def test_dropped_attributes(self):
14901490
self.assertEqual(3, span.dropped_events)
14911491
self.assertEqual(2, span.events[0].attributes.dropped)
14921492
self.assertEqual(2, span.links[0].attributes.dropped)
1493-
self.assertEqual(2, span.resource.attributes.dropped)
14941493

14951494
def _test_span_limits(
14961495
self,

0 commit comments

Comments
 (0)