Skip to content

Commit aaf88ea

Browse files
author
Nicolas Marier
committed
fix(baggage): oversized header warn only with a header
This commit makes sure that warnings about the baggage header length are only emitted when the header is actually present, since it does not make sense to warn about a missing header's length.
1 parent 39fe4db commit aaf88ea

File tree

1 file changed

+5
-4
lines changed
  • opentelemetry-api/src/opentelemetry/baggage/propagation

1 file changed

+5
-4
lines changed

Diff for: opentelemetry-api/src/opentelemetry/baggage/propagation/__init__.py

+5-4
Original file line numberDiff line numberDiff line change
@@ -54,10 +54,11 @@ def extract(
5454
)
5555

5656
if not header or len(header) > self._MAX_HEADER_LENGTH:
57-
_logger.warning(
58-
"Baggage header `%s` exceeded the maximum number of bytes per baggage-string",
59-
header,
60-
)
57+
if header:
58+
_logger.warning(
59+
"Baggage header `%s` exceeded the maximum number of bytes per baggage-string",
60+
header,
61+
)
6162
return context
6263

6364
baggage_entries = split(_DELIMITER_PATTERN, header)

0 commit comments

Comments
 (0)