comments

Author: aabmass

Diff for: exporter/opentelemetry-exporter-otlp/src/opentelemetry/exporter/otlp/exporter.py

@@ -61,14 +61,23 @@
 }
 
 
-def environ_to_compression(environ_key: str) -> Optional[Compression]:
-    environ_value = environ.get(environ_key)
-    if environ_value not in _ENVIRON_TO_COMPRESSION:
-        raise Exception(
+class InvalidCompressionValueException(Exception):
+    def __init__(self, environ_key: str, environ_value: str):
+        super().__init__(
             'Invalid value "{}" for compression envvar {}'.format(
                 environ_value, environ_key
             )
         )
+
+
+def environ_to_compression(environ_key: str) -> Optional[Compression]:
+    environ_value = (
+        environ[environ_key].lower().strip()
+        if environ_key in environ
+        else None
+    )
+    if environ_value not in _ENVIRON_TO_COMPRESSION:
+        raise InvalidCompressionValueException(environ_key, environ_value)
     return _ENVIRON_TO_COMPRESSION[environ_value]
 
 

Diff for: exporter/opentelemetry-exporter-otlp/src/opentelemetry/exporter/otlp/trace_exporter/__init__.py

@@ -70,6 +70,7 @@ class OTLPSpanExporter(
         credentials: Credentials object for server authentication
         headers: Headers to send when exporting
         timeout: Backend request timeout in seconds
+        compression: gRPC compression method to use
     """
 
     _result = SpanExportResult

Diff for: exporter/opentelemetry-exporter-otlp/tests/test_otlp_exporter_mixin.py

@@ -1,3 +1,17 @@
+# Copyright The OpenTelemetry Authors
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
 from unittest import TestCase
 from unittest.mock import patch
 
@@ -12,13 +26,20 @@ def test_environ_to_compression(self):
             "os.environ",
             {
                 "test_gzip": "gzip",
+                "test_gzip_caseinsensitive_with_whitespace": " GzIp ",
                 "test_deflate": "deflate",
                 "test_invalid": "some invalid compression",
             },
         ):
             self.assertEqual(
                 environ_to_compression("test_gzip"), Compression.Gzip
             )
+            self.assertEqual(
+                environ_to_compression(
+                    "test_gzip_caseinsensitive_with_whitespace"
+                ),
+                Compression.Gzip,
+            )
             self.assertEqual(
                 environ_to_compression("test_deflate"), Compression.Deflate
             )