Skip to content

Commit b7450eb

Browse files
committed
Implement small requested changes
1 parent 7a0c286 commit b7450eb

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

opentelemetry-sdk/src/opentelemetry/sdk/resources/__init__.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,7 @@ def merge(self, other: "Resource") -> "Resource":
217217
elif self.schema_url == other.schema_url:
218218
schema_url = other.schema_url
219219
else:
220-
schema_url = "merge-conflict"
220+
schema_url = ""
221221
logger.error(
222222
"Failed to merge resources: The Schema URL of the old and updating resources are not empty and are different"
223223
)

opentelemetry-sdk/tests/resources/test_resources.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@ def test_create(self):
5252
resource = resources.Resource.create(attributes)
5353
self.assertIsInstance(resource, resources.Resource)
5454
self.assertEqual(resource.attributes, expected_attributes)
55+
self.assertEqual(resource.schema_url, "")
5556

5657
schema_url = "https://opentelemetry.io/schemas/1.3.0"
5758

@@ -146,7 +147,7 @@ def test_resource_merge(self):
146147
left = resources.Resource.create({}, schema_urls[0])
147148
right = resources.Resource.create({}, schema_urls[1])
148149
with self.assertLogs(level=ERROR):
149-
left.merge(right)
150+
self.assertEqual(left.merge(right).schema_url, "")
150151

151152
def test_resource_merge_empty_string(self):
152153
"""Verify Resource.merge behavior with the empty string.

0 commit comments

Comments
 (0)