File tree 3 files changed +5
-3
lines changed
opentelemetry-api/src/opentelemetry/trace
opentelemetry-sdk/src/opentelemetry/sdk/trace
3 files changed +5
-3
lines changed Original file line number Diff line number Diff line change @@ -17,6 +17,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
17
17
([ #3648 ] ( https://github.com/open-telemetry/opentelemetry-python/pull/3648 ) )
18
18
- Fix ValueError message for PeriodicExportingMetricsReader
19
19
([ #3769 ] ( https://github.com/open-telemetry/opentelemetry-python/pull/3769 ) )
20
+ - Use ` BaseException ` instead of ` Exception ` in ` record_exception `
21
+ ([ #3354 ] ( https://github.com/open-telemetry/opentelemetry-python/pull/3354 ) )
20
22
- Make span.record_exception more robust
21
23
([ #3778 ] ( https://github.com/open-telemetry/opentelemetry-python/pull/3778 ) )
22
24
- Fix license field in pyproject.toml files
Original file line number Diff line number Diff line change @@ -169,7 +169,7 @@ def set_status(
169
169
@abc .abstractmethod
170
170
def record_exception (
171
171
self ,
172
- exception : Exception ,
172
+ exception : BaseException ,
173
173
attributes : types .Attributes = None ,
174
174
timestamp : typing .Optional [int ] = None ,
175
175
escaped : bool = False ,
@@ -563,7 +563,7 @@ def set_status(
563
563
564
564
def record_exception (
565
565
self ,
566
- exception : Exception ,
566
+ exception : BaseException ,
567
567
attributes : types .Attributes = None ,
568
568
timestamp : typing .Optional [int ] = None ,
569
569
escaped : bool = False ,
Original file line number Diff line number Diff line change @@ -983,7 +983,7 @@ def __exit__(
983
983
984
984
def record_exception (
985
985
self ,
986
- exception : Exception ,
986
+ exception : BaseException ,
987
987
attributes : types .Attributes = None ,
988
988
timestamp : Optional [int ] = None ,
989
989
escaped : bool = False ,
You can’t perform that action at this time.
0 commit comments