Skip to content

Commit c750109

Browse files
authored
Remove rate property setter from TraceIdRatioBasedSampler (#1536)
1 parent d994e75 commit c750109

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed

CHANGELOG.md

+2
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
6464
([#1525](https://github.com/open-telemetry/opentelemetry-python/pull/1525))
6565
- `opentelemetry-exporter-jaeger`, `opentelemetry-exporter-zipkin` Update InstrumentationInfo tag keys for Jaeger and Zipkin exporters
6666
([#1535](https://github.com/open-telemetry/opentelemetry-python/pull/1535))
67+
- `opentelemetry-sdk` Remove rate property setter from TraceIdRatioBasedSampler
68+
([#1536](https://github.com/open-telemetry/opentelemetry-python/pull/1536))
6769

6870
### Removed
6971
- `opentelemetry-api` Remove ThreadLocalRuntimeContext since python3.4 is not supported.

opentelemetry-sdk/src/opentelemetry/sdk/trace/sampling.py

-5
Original file line numberDiff line numberDiff line change
@@ -233,11 +233,6 @@ def get_bound_for_rate(cls, rate: float) -> int:
233233
def rate(self) -> float:
234234
return self._rate
235235

236-
@rate.setter
237-
def rate(self, new_rate: float) -> None:
238-
self._rate = new_rate
239-
self._bound = self.get_bound_for_rate(self._rate)
240-
241236
@property
242237
def bound(self) -> int:
243238
return self._bound

0 commit comments

Comments
 (0)