Add validation for Trace ID

Author: ymotongpoo

opentelemetry-api/src/opentelemetry/trace/span.py

@@ -390,6 +390,24 @@ def values(self) -> typing.ValuesView[str]:
 
 DEFAULT_TRACE_STATE = TraceState.get_default()
 
+_TRACE_ID_BYTES = 16
+_TRACE_ID_HEX_LENGTH = 2 * _TRACE_ID_BYTES
+
+def _validate_trace_id(trace_id: int) -> bool:
+    """Validates a trace_id.
+
+    Args:
+        trace_id: An int that is expected to corresponds to 16-bytes hexdecimal value
+
+    Returns:
+        True if trace_id is valid, False otherwise.
+    """
+    if not trace_id:
+        return False
+    if len(format(trace_id, "032x")) != _TRACE_ID_HEX_LENGTH:
+        return False
+
+    return True
 
 class SpanContext(
     typing.Tuple[int, int, bool, "TraceFlags", "TraceState", bool]
@@ -420,7 +438,7 @@ def __new__(
         if trace_state is None:
             trace_state = DEFAULT_TRACE_STATE
 
-        is_valid = trace_id != INVALID_TRACE_ID and span_id != INVALID_SPAN_ID
+        is_valid = trace_id != INVALID_TRACE_ID and span_id != INVALID_SPAN_ID and _validate_trace_id(trace_id)
 
         return tuple.__new__(
             cls,

opentelemetry-api/tests/trace/test_span_context.py

@@ -34,3 +34,12 @@ def test_span_context_pickle(self):
         pickle_sc = pickle.loads(pickle.dumps(sc))
         self.assertEqual(sc.trace_id, pickle_sc.trace_id)
         self.assertEqual(sc.span_id, pickle_sc.span_id)
+
+        invalid_sc = trace.SpanContext(
+            9999999999999999999999999999999999999999999999999999999999999999999999999999,
+            9,
+            is_remote=False,
+            trace_flags=trace.DEFAULT_TRACE_OPTIONS,
+            trace_state=trace.DEFAULT_TRACE_STATE,
+        )
+        self.assertFalse(invalid_sc.is_valid)