Skip to content

Commit cdd760b

Browse files
committed
Move return inside the lock
1 parent f005176 commit cdd760b

File tree

1 file changed

+14
-14
lines changed

1 file changed

+14
-14
lines changed

opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/metric_reader_storage.py

+14-14
Original file line numberDiff line numberDiff line change
@@ -230,21 +230,21 @@ def collect(self) -> Optional[MetricsData]:
230230
instrument.instrumentation_scope
231231
].metrics.extend(metrics)
232232

233-
if instrumentation_scope_scope_metrics:
234-
235-
return MetricsData(
236-
resource_metrics=[
237-
ResourceMetrics(
238-
resource=self._sdk_config.resource,
239-
scope_metrics=list(
240-
instrumentation_scope_scope_metrics.values()
241-
),
242-
schema_url=self._sdk_config.resource.schema_url,
243-
)
244-
]
245-
)
233+
if instrumentation_scope_scope_metrics:
234+
235+
return MetricsData(
236+
resource_metrics=[
237+
ResourceMetrics(
238+
resource=self._sdk_config.resource,
239+
scope_metrics=list(
240+
instrumentation_scope_scope_metrics.values()
241+
),
242+
schema_url=self._sdk_config.resource.schema_url,
243+
)
244+
]
245+
)
246246

247-
return None
247+
return None
248248

249249
def _handle_view_instrument_match(
250250
self,

0 commit comments

Comments
 (0)