Remove time_ns

Author: ocelotl

opentelemetry-api/src/opentelemetry/trace/__init__.py

@@ -79,6 +79,7 @@
 from enum import Enum
 from logging import getLogger
 from typing import Iterator, Optional, Sequence, cast
+from sys import version_info
 
 from opentelemetry.context.context import Context
 from opentelemetry.environment_variables import OTEL_PYTHON_TRACER_PROVIDER
@@ -108,6 +109,27 @@
 logger = getLogger(__name__)
 
 
+if version_info.minor < 7:
+
+    logger.warning(
+        "Your current Python version does not support time measurements with"
+        " nanosecond precision. time_ns is being added as an attribute of the"
+        " time module to provide an uniform way of importing a timestamping"
+        " function from this module but it must not be relied on providing"
+        " actual nanosecond precision for timestamps. More information in "
+        " PEP 564. Please upgrade to Python  3.7 or newer."
+    )
+
+    from time import time
+
+    def time_ns() -> int:
+        # FIXME this approach can have precision problems as explained here:
+        # https://github.com/open-telemetry/opentelemetry-python/issues/1594
+        return int(time() * 1e9)
+
+    time.time_ns = time_ns
+
+
 class LinkBase(ABC):
     def __init__(self, context: "SpanContext") -> None:
         self._context = context

opentelemetry-api/src/opentelemetry/util/time.py

@@ -20,6 +20,7 @@
 import logging
 import threading
 import traceback
+from time import time_ns
 from collections import OrderedDict
 from contextlib import contextmanager
 from os import environ
@@ -57,7 +58,6 @@
 from opentelemetry.trace.propagation import SPAN_KEY
 from opentelemetry.trace.status import Status, StatusCode
 from opentelemetry.util import types
-from opentelemetry.util.time import time_ns
 
 logger = logging.getLogger(__name__)
 

opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py

@@ -17,6 +17,7 @@
 import sys
 import threading
 import typing
+from time import time_ns
 from enum import Enum
 from os import environ, linesep
 from typing import Optional
@@ -29,7 +30,6 @@
     OTEL_BSP_SCHEDULE_DELAY,
 )
 from opentelemetry.sdk.trace import ReadableSpan, Span, SpanProcessor
-from opentelemetry.util.time import time_ns
 
 logger = logging.getLogger(__name__)
 

opentelemetry-sdk/src/opentelemetry/sdk/trace/export/__init__.py

@@ -20,6 +20,7 @@
 from logging import ERROR, WARNING
 from typing import Optional
 from unittest import mock
+from time import time_ns
 
 import pytest
 
@@ -38,7 +39,6 @@
 from opentelemetry.sdk.util import ns_to_iso_str
 from opentelemetry.sdk.util.instrumentation import InstrumentationInfo
 from opentelemetry.trace.status import StatusCode
-from opentelemetry.util.time import time_ns
 
 
 def new_tracer() -> trace_api.Tracer:

opentelemetry-sdk/tests/trace/test_trace.py

@@ -12,11 +12,10 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-import time
+from time import time, time_ns
 import unittest
 
 from opentelemetry.shim.opentracing_shim import util
-from opentelemetry.util.time import time_ns
 
 
 class TestUtil(unittest.TestCase):
@@ -39,7 +38,7 @@ def test_event_name_from_kv(self):
         self.assertEqual(res, util.DEFAULT_EVENT_NAME)
 
     def test_time_seconds_to_ns(self):
-        time_seconds = time.time()
+        time_seconds = time()
         result = util.time_seconds_to_ns(time_seconds)
 
         self.assertEqual(result, int(time_seconds * 1e9))