Skip to content

Commit d731803

Browse files
committed
fix: added checking the actual log message to percent-format test
1 parent 4a2a984 commit d731803

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

opentelemetry-sdk/tests/logs/test_handler.py

+6-2
Original file line numberDiff line numberDiff line change
@@ -267,20 +267,24 @@ def test_log_body_is_always_string(self):
267267
self.assertIsInstance(log_record.body, str)
268268

269269
def test_args_get_transformed_if_logged(self):
270-
with set_up_test_logging(logging.WARNING) as (_, logger):
270+
with set_up_test_logging(logging.WARNING) as (processor, logger):
271271

272272
my_object = MagicMock()
273+
my_object.__str__.return_value = "foo"
274+
my_object.__int__.return_value = 42
273275
logger.warning("%s - %d", my_object, my_object)
274276

277+
self.assertEqual(processor.get_log_record(0).body, "foo - 42")
275278
self.assertTrue(my_object.__str__.called)
276279
self.assertTrue(my_object.__int__.called)
277280

278281
def test_args_do_not_get_transformed_if_not_logged(self):
279-
with set_up_test_logging(logging.WARNING) as (_, logger):
282+
with set_up_test_logging(logging.WARNING) as (processor, logger):
280283

281284
my_object = MagicMock()
282285
logger.info("%s - %d", my_object, my_object)
283286

287+
self.assertEqual(processor.log_data_emitted, [])
284288
self.assertFalse(my_object.__str__.called)
285289
self.assertFalse(my_object.__int__.called)
286290

0 commit comments

Comments
 (0)