opentelemetry-bootstrap -a install shouldn't upgrade libraries

[codeboten]

Describe your environment
The opentelemetry-bootstrap install option currently searches for installed libraries and instrumentations to match those libraries which is really useful. However, some of those instrumentation libraries will have the side effect of upgrading the libraries they're instrumenting, which is unexpected.

Steps to reproduce

pip install tornado==4.0
pip freeze | grep tornado
tornado==4.0
opentelemetry-bootstrap -a install
pip freeze | grep tornado
opentelemetry-instrumentation-tornado==0.17b0
tornado==6.1

What is the expected behavior?
The instrumentation library should not have been installed

What is the actual behavior?
tornado was upgraded

[srikanthccv]

Ahh, I ran into this problem. What do you think about the idea of instrumentations not installing library and expect it to be installed by user? One potential problem could be instrumentation library may not be compatible with instrumented library version.

[owais]

Thanks for linking to this issue @lonewolf3739. @codeboten I think we should just get rid of bootstrap and all such issues caused by instrumentation libraries depending on target libraries. #1729

[srikanthccv]

Hmm

$ python -m pip install opentelemetry-instrumentation-tornado==0.17b0
...
...
Successfully installed opentelemetry-api-0.17b0 opentelemetry-instrumentation-0.17b0 opentelemetry-instrumentation-tornado-0.17b0 tornado-6.1
$ python -m pip install tornado==4.0
...
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
opentelemetry-instrumentation-tornado 0.17b0 requires tornado>=6.0, but you have tornado 4.0 which is incompatible.

installation in different order doesn't show conflict error?

$ python -m pip install tornado==4.0
...
...
$ python -m pip install opentelemetry-instrumentation-tornado==0.17b0
...
Installing collected packages: tornado, opentelemetry-instrumentation-tornado
  Attempting uninstall: tornado
    Found existing installation: tornado 4.0
    Uninstalling tornado-4.0:
      Successfully uninstalled tornado-4.0
Successfully installed opentelemetry-instrumentation-tornado-0.17b0 tornado-6.1

I would have expected it to behave same in both cases.

[lzchen]

I would have expected it to behave same in both cases.

Isn't the reason because we pinned the tornado version to >=6.0? What is the issue here?

[codeboten]

Moved to discussion: #1729