-
Notifications
You must be signed in to change notification settings - Fork 698
Batch Span Processor does not work with uwsgi #2266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
//cc @lonewolf3739 |
Also tested with Celery and it does not work when worker's |
That change wasn't effective for uwsgi since it's worker proc management implementation is in C. I might have overlooked it when verifying, my apologies. We can probably make use of pid at the time of instantiation and processing to reinitialise. Can you share the more details about how you tested celery? I tried to set the option to given values but was able to see the spans emitted. |
No worries at all. I just wanted to document what works and what doesn't somewhere so we can track it and patch it at some point. |
On celery:
|
@lonewolf3739 My bad. Celery actually works but only if I remove this special case from the sitecustomize file: https://github.com/open-telemetry/opentelemetry-python-contrib/blob/main/opentelemetry-instrumentation/src/opentelemetry/instrumentation/auto_instrumentation/sitecustomize.py#L128-L141 |
Recently support for forking web servers landed in Batch Span Processor in #2242
I tested this and it works with gunicorn but does not work with uwsgi.
Given a file called
myapp.py
:The following command works reports spans
While as this does not
I added some debug statements to the fork hook and it seems the hook is called with gunicorn but not with uwsgi.
We should look into how uwsgi works and confirm whether the solution work with it or not.
The text was updated successfully, but these errors were encountered: