Skip to content

Loosen up the dependency on backoff. #2384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kaos opened this issue Jan 18, 2022 · 3 comments · Fixed by #2575
Closed

Loosen up the dependency on backoff. #2384

kaos opened this issue Jan 18, 2022 · 3 comments · Fixed by #2575

Comments

@kaos
Copy link

kaos commented Jan 18, 2022

When trying to install opentelemetry-exporter-otlp-proto-gprc we hit a dependency issue involving backoff.

ERROR: Cannot install -r requirements.txt (line 42), backoff==1.11.1 and opentelemetry-exporter-otlp because these package versions have conflicting dependencies.

The conflict is caused by:
    The user requested backoff==1.11.1
    <redacted> 6.18.0 depends on backoff<2.0.0 and >=1.11.1
    opentelemetry-exporter-otlp-proto-grpc 1.8.0 depends on backoff~=1.10.0

To fix this you could try to:
1. loosen the range of package versions you've specified
2. remove package versions to allow pip attempt to solve the dependency conflict

Is there an issue with backoff 1.11.1 that makes it unusable for this project?
If not, I'd suggest using a less restrictive requirement, that allows minor and patch upgrades.

@srikanthccv
Copy link
Member

Our usage of this lib is only limited to definition expo. I don't see any breaking changes to that since the initial release of package. Would appreciate if you can test and send a PR Loosening up the requirement.

@kaos
Copy link
Author

kaos commented Jan 21, 2022

Would appreciate if you can test and send a PR Loosening up the requirement.

OK! Thanks, I'll see if I can do that when I get some spare time, unless someone else beats me to it (not going to be too soon). I've worked around this by pinning our deps to backoff 1.10.0 as well for now.

@teddylear
Copy link
Contributor

@aabmass @srikanthccv Made small PR to address this. Looks like I need approval fro CI jobs as this is my first PR to the project. Please let me know if I should change anything, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants